django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Add parser and importer for Vulners.com reports API

Open vankyver opened this issue 3 years ago • 9 comments

Adding vulners.com reports parser.

vankyver avatar Aug 11 '22 19:08 vankyver

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 19 '22 14:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 24 '22 07:08 github-actions[bot]

@damiencarol Looks like all required fixes done. Can we finalise review?

vankyver avatar Aug 24 '22 08:08 vankyver

@vankyver :

Made a review of the official SDK and it support proxies.

https://github.com/vulnersCom/api/blob/f56dab4ffcdb400da58b680d7feb89cae3550984/vulners/api.py#L97-L105

image

damiencarol avatar Aug 27 '22 21:08 damiencarol

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 01 '22 00:09 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Sep 08 '22 20:09 github-actions[bot]

@vankyver :

Made a review of the official SDK and it support proxies.

https://github.com/vulnersCom/api/blob/f56dab4ffcdb400da58b680d7feb89cae3550984/vulners/api.py#L97-L105

image

@damiencarol I've added fixes with including Vulners SDK

vankyver avatar Sep 08 '22 20:09 vankyver

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 11 '22 23:09 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Sep 12 '22 06:09 github-actions[bot]

@damiencarol Wanted to give you a chance to look at this before it gets merged since you had comments above.

mtesauro avatar Sep 27 '22 21:09 mtesauro

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 29 '22 19:09 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Sep 30 '22 06:09 github-actions[bot]

@vankyver will merge after the release.

devGregA avatar Sep 30 '22 18:09 devGregA

@vankyver will review this WE. saw a couple of things to slightly modify

damiencarol avatar Oct 08 '22 10:10 damiencarol

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 10 '22 14:10 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Oct 10 '22 17:10 github-actions[bot]

@vankyver please see feedback from Damien

Maffooch avatar Oct 26 '22 03:10 Maffooch

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 01 '22 03:11 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Nov 06 '22 12:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 20 '22 00:11 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Nov 20 '22 16:11 github-actions[bot]

As @vankyver did not reply over a month, would it be an option to make another PR including these changes plus the requested changes from @damiencarol and close this PR?

manuel-sommer avatar Nov 20 '22 19:11 manuel-sommer

@manuel-sommer that is cool with me!

Maffooch avatar Nov 20 '22 21:11 Maffooch

@manuel-sommer , @Maffooch : if @vankyver is ok, I can "finish" the PR.

damiencarol avatar Nov 21 '22 08:11 damiencarol

@damiencarol either way works! This PR has two approvals so you could change and merge at your timeline

Maffooch avatar Nov 21 '22 15:11 Maffooch

Hi, sorry, hard month, going to come back with changes asap.

vankyver avatar Nov 22 '22 16:11 vankyver

@damiencarol Was looking at this and was about to merge since it has 2 approvals but couldn't tell from the thread if there was work you still wanted to do.

So, I'll wait to give you a chance to chime it or address the changes you requested. :+1:

mtesauro avatar Nov 26 '22 18:11 mtesauro

@damiencarol From my point of view, everything is ready, so I hope that now we can complete the pull request.

vankyver avatar Nov 29 '22 07:11 vankyver

Great work @vankyver

damiencarol avatar Dec 04 '22 21:12 damiencarol