django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

[FIX] JQuery Error on Edit Finding

Open X0x1RG9f opened this issue 3 years ago • 5 comments

When editing a finding, a click on the "See Alerts" button at the right corner of the webpage will cause a JQuery JavaScript Error. Removing JQuery usage and using JS trim instead.

X0x1RG9f avatar Jul 28 '22 12:07 X0x1RG9f

Helm charts will not pass because X0x1RG9f:X0x1RG9f-fix8 is based from master

Maffooch avatar Jul 30 '22 18:07 Maffooch

@X0x1RG9f could you rebase on last dev ? the failing test was fixed in dev.

damiencarol avatar Aug 13 '22 14:08 damiencarol

Got a whole bunch of extra stuff in here now :/

Maffooch avatar Aug 16 '22 20:08 Maffooch

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 17 '22 07:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 17 '22 07:08 github-actions[bot]

@blakeaowens no need to test, if the JS change looks safe to you, please just let me know.

devGregA avatar Sep 27 '22 20:09 devGregA

@devGregA Change looks fine to me.

blakeaowens avatar Sep 27 '22 22:09 blakeaowens