django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Helm Chart: Create PVC as part of the Chart

Open OlaniyiOdeleye opened this issue 3 years ago • 13 comments

Managing a persistent volume claim outside the Chart seems to be stressful. The Chart should be self-sufficient hence, the reason for creating this PR.

OlaniyiOdeleye avatar May 09 '22 14:05 OlaniyiOdeleye

At the first place I wanted to do the same, but then came to opinion that is better to force consumers to do it by themself manually, just to prove that they know what do they do, before potentially they will destroy their data.

dsever avatar May 09 '22 16:05 dsever

Please fix Linting problem, then I will test the feature.

dsever avatar May 11 '22 07:05 dsever

Please fix Linting problem, then I will test the feature.

Done, linting problem fixed.

OlaniyiOdeleye avatar May 11 '22 08:05 OlaniyiOdeleye

Please fix Linting problem, then I will test the feature.

Done, linting problem fixed.

Is is problem to launch PR from

Please fix Linting problem, then I will test the feature.

Done, linting problem fixed.

Cool, I will test it.

dsever avatar May 13 '22 06:05 dsever

Please fix Linting problem, then I will test the feature.

Done, linting problem fixed.

Is is problem to launch PR from

Please fix Linting problem, then I will test the feature.

Done, linting problem fixed.

Cool, I will test it.

Any update with the testing?

OlaniyiOdeleye avatar May 17 '22 12:05 OlaniyiOdeleye

@OlaniyiOdeleye please fix linting problem

dsever avatar May 26 '22 13:05 dsever

@dsever, any update on why the pull request is getting closed and opened?

OlaniyiOdeleye avatar Jun 14 '22 11:06 OlaniyiOdeleye

I was re triggering the test executions, but looks it keeps failing.

dsever avatar Jun 14 '22 11:06 dsever

I was re triggering the test executions, but looks it keeps failing.

I believe there is nothing left to be updated from my side right?

OlaniyiOdeleye avatar Jun 14 '22 11:06 OlaniyiOdeleye

@OlaniyiOdeleye can you rebase it against of dev repo?

dsever avatar Jun 18 '22 23:06 dsever

@OlaniyiOdeleye can you rebase it against of dev repo?

Done

OlaniyiOdeleye avatar Jun 19 '22 22:06 OlaniyiOdeleye

@OlaniyiOdeleye can you rebase it against of dev repo?

Done

@dsever any luck with this?

OlaniyiOdeleye avatar Jul 14 '22 07:07 OlaniyiOdeleye

It looks ok, but I will read instructions twice, not to confuse consumers.

dsever avatar Jul 14 '22 11:07 dsever

@OlaniyiOdeleye, I apologize for the delay. Our helm experts are out right now.

devGregA avatar Sep 30 '22 18:09 devGregA

Not sure why you're getting flake8 failures when you didn't touch any .py files. I'll go ahead and merge this.

mtesauro avatar Oct 07 '22 14:10 mtesauro