django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

:bug: fix Nuclei deduplication #12397

Open manuel-sommer opened this issue 7 months ago • 4 comments

#12397

manuel-sommer avatar May 07 '25 19:05 manuel-sommer

DryRun Security

This pull request introduces a potential security concern with the new 'endpoints' attribute in Nuclei Scan configuration, which might inadvertently expose sensitive network or infrastructure details if not carefully managed.

:thought_balloon: Unconfirmed Findings (1)
Vulnerability Potential Information Exposure via Endpoint Tracking
Description The new 'endpoints' attribute in Nuclei Scan configuration may expose detailed network or application endpoint information. This could lead to unintended revelation of sensitive infrastructure details if access and visibility are not properly controlled, presenting a potential security risk through expanded metadata tracking.

All finding details can be found in the DryRun Security Dashboard.

dryrunsecurity[bot] avatar May 07 '25 19:05 dryrunsecurity[bot]

Maybe the parser must be updated to mark the findings as dynamic?

I was thinking something similar. Some parsers aggregate endpoints by their finding. I think that should be implemented here as well. Tenable is great example of this use case

Maffooch avatar May 08 '25 15:05 Maffooch

Hm, I am not really sure how to proceed here. You are right @valentijnscholten, I wasn't aware that endpoints are always considered. Furthermore, the Finding is dynamic by default: https://github.com/DefectDojo/django-DefectDojo/blob/924c2c88645ad555193f9122c5eba2dc7bd5c65c/dojo/models.py#L2542

manuel-sommer avatar May 15 '25 09:05 manuel-sommer

So, it means that if the findings have different endpoints, they shouldn't be closed as duplicates. But based on my testing and the screenshot I provided, they are still being closed as duplicates

egorbeliy avatar Jun 16 '25 10:06 egorbeliy

Closing as stale

Maffooch avatar Jul 16 '25 16:07 Maffooch