StyleFrame
StyleFrame copied to clipboard
Beginning refactor `to_excel()`
As discussed in #135
- The
indexnow is an explicit argument into_excel()with defaultFalse(differing from pandas default). This is to make it clear to the user that there is a difference between StyleFrame- and Pandas-default for that argument. - Setting the default's for
header,startcol,startrowandna_repnow moved to an own method (_to_excel_pandas_defaults()). This makes it easier to test this piece of code and make the code ofto_excel()more clear.
Sidenode: There are nearly no docstrings in the unittests I am not sure how the structure of the test cases is and what are the intentions behind all that classes and cases. Because of that I decided just to create a new test class focusing on to_excel() only.
Codecov Report
Base: 90.74% // Head: 90.71% // Decreases project coverage by -0.03% :warning:
Coverage data is based on head (
f760b40) compared to base (c70243d). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## devel #139 +/- ##
==========================================
- Coverage 90.74% 90.71% -0.04%
==========================================
Files 18 18
Lines 1534 1561 +27
==========================================
+ Hits 1392 1416 +24
- Misses 142 145 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| styleframe/style_frame.py | 86.65% <100.00%> (+0.08%) |
:arrow_up: |
| styleframe/tests/style_frame_tests.py | 99.42% <100.00%> (+0.02%) |
:arrow_up: |
| styleframe/styler.py | 78.62% <0.00%> (-1.24%) |
:arrow_down: |
| styleframe/utils.py | 99.14% <0.00%> (+0.03%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
btw: It is still not clear for me how long your code lines are. Where do you break your lines?
I need this value to modify my environment which use the default value of 80.
Did I missed something in the GitHub webfrontend here? Do I have to do something else? Or can we merge it?
For me this PR was just a warm up for refactoring the to_excel(). So I would like to start.
Can you help me here? I changed what you requested. But GitHub still mark this PR as "changes requested".
Can you deal with it?
Please not that you only resolved my suggestions, but didn't apply them. I did that for you and will merge this PR.
Thanks for contributing! :)
Please not that you only resolved my suggestions, but didn't apply them.
What means apply?
Please see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request