good-first-issue icon indicating copy to clipboard operation
good-first-issue copied to clipboard

Feat/#365 add sorting

Open TakasiVenkataSandeep-08 opened this issue 3 years ago • 3 comments

Changes or features added through this PR

  1. Added sort by and order by feature for both /language/_slug and / routes

Explanation for the changes introduces

  1. Created a independent component to handle sort by and order by functionality
  2. Created required state variables and mutations required for sort by and order by functionality
  3. Added sort by and order by sections in sidebar
  4. Added sort by and order by repos functionality to pages/language/_slug.vue and pages/index.vue

This PR fixes issue #365

UPDATE: Changes to fix issues shown in DeepSource javascript check

  1. Moved the repo and sorting related mutations to repo.js and sorting.js respectively in mutations folder in store this improves better code maintainability.

TakasiVenkataSandeep-08 avatar Jul 06 '22 05:07 TakasiVenkataSandeep-08

Hi @siddhant-deepsource sorry to bother you at this time but any updates on this pr?

TakasiVenkataSandeep-08 avatar Aug 02 '22 08:08 TakasiVenkataSandeep-08

hi @shivam-deepsource,

i appreciate your review on this pr i have made all the changes you suggested but i still have one doubt that what should be the ui for order by and shall i remove it for now? and hope these changes are okay! please let me know if any other changes are needed

Thanks!

TakasiVenkataSandeep-08 avatar Aug 03 '22 07:08 TakasiVenkataSandeep-08

Hey @TakasiVenkataSandeep-08 ! I tried to contribute to this repo as well but I haven't seen any activity in the last few months. I decided to fork it to keep it alive. Please see https://github.com/lucavallin/gfi and feel free to open a pull request there. At this time I am setting up the hosting and cleaning up the code. If you're up for it, I could use some help to convert the app from Nuxt.js & Python to Next.js & Typescript.

lucavallin avatar Dec 21 '22 16:12 lucavallin