DeeDeeG
DeeDeeG
This looks like a huge effort re-writing this entire file! I can confirm this does fix the issue for me on Windows with Unicode characters in the Python path. \[EDIT:...
@owl-from-hogvarts I'm not sure why the tests/CI is not running here. (Reminder: I am not part of the node-gyp team, so I personally can't fix CI here.) But you can...
@owl-from-hogvarts hmm, there is a merge conflict from my PRs. Sorry about that. I believe this pull request has changed `lib/find-python.js` to have Windows line endings (CRLF). And this PR...
@owl-from-hogvarts this branch has overwritten/undone the change I made in https://github.com/nodejs/node-gyp/pull/2375. I suppose you can re-apply it by doing git cherry-pick -x fca4795512c67dc8420aaa0d913b5b89a4b147f3. Note about merge conflicts (click to expand...
I haven't written a `binding.gyp` file before, and I don't do a lot with C/C++ to be honest (or go/other compiled languages). I don't know a lot about how the...
Hi, thanks for the ping. I have to say the commands modified in this PR _should_ work without modification on Unix-like OSes. Linux and macOS, mainly. For what it's worth,...
Still need to find time to post a PR for this. I hope this isn't holding up v9 -- I guess it could go in a v10 or v11 just...
For what it's worth, I think having an empty `binding.gyp` always produces the second error `SyntaxError: invalid syntax` when trying to read `binding.gyp`. So that troubleshooting does not make the...
I think this is fine as an automated database query, *with the caveat* that there are some false-positives in most, if not all of these queries, and manual vetting is...
Sure. I'm not yet certain whether we would post to it, but having the option to make posts should be a good thing. P.S. Thanks for your interest in the...