final-form-material-ui icon indicating copy to clipboard operation
final-form-material-ui copied to clipboard

TextField does not animate properly

Open NawarA opened this issue 6 years ago • 7 comments
trafficstars

Bug:

Classes are not being passed down properly on focus.

For example, if you click a TextField with variant outline, the class does not get passed down properly, so no animation effect is seen when using this library. Compare the behavior of a <TextField variant=filled> with a <TextField variant=filled> from the material-ui/core and you'll notice the difference in behavior.

Easy Fix:

Fix found at: https://github.com/final-form/react-final-form/issues/294

Change inputProps to InputProps. Then everything works normally. Confirmed the fix works.

Can you please make this fix and release?

NawarA avatar Dec 17 '18 15:12 NawarA

Has @NawarA saids this fix the animation. Please @Deadly0 let us know if you will merge this request. Thanks

sfblaauw avatar Mar 16 '19 17:03 sfblaauw

I can confirm that the fix works. From the docs Skärmavbild 2019-03-19 kl  23 10 13

I guess InputProps is the correct prop to use?

andidev avatar Mar 19 '19 22:03 andidev

Btw this also messes up the placeholder text. It gets squashed with the label for some reason. The fix fixes this issue as well.

andidev avatar Mar 19 '19 22:03 andidev

This bug also makes the a form value of a blank string submit as undefined (when it should submit as a blank string). The InputProps change fixes this as well.

andidev avatar Mar 19 '19 22:03 andidev

I've run into this issue as well. Thanks for the work around. One more vote for a merge.

tobytraylor avatar May 01 '19 07:05 tobytraylor

Oh no... is this project dead?

tobytraylor avatar May 02 '19 15:05 tobytraylor

this issue is causing so many bugs and should be merged long time ago.

Is someone willing to fork this and maintain it? Or just ask @Deadly0 to replace him as a maintainer

I would do it, but I do not know typescript.

zsolt-dev avatar May 31 '19 10:05 zsolt-dev