Antoine Langlois

Results 26 comments of Antoine Langlois

> Thanks! I noticed there's still a few unaddressed feedback threads, maybe they were hidden by github and you didn't spot them? > > ![image](https://private-user-images.githubusercontent.com/5046562/382601500-e4977bb4-24b5-4f15-a993-c015adc19483.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA2Njc2NjEsIm5iZiI6MTczMDY2NzM2MSwicGF0aCI6Ii81MDQ2NTYyLzM4MjYwMTUwMC1lNDk3N2JiNC0yNGI1LTRmMTUtYTk5My1jMDE1YWRjMTk0ODMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMDNUMjA1NjAxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWIzNTk1NDRhYWNjOWI5NWVmNTUxNDNiOWMyMDUwYTI1MTZiYjUxODQ4ZjI3YzhhY2ZkMTE5ZTg1NGE0ZTNjNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.rvCvXurC441hlZ2r1kGKN53D8no1BycTutiKpVGk9_I) > > On the whole...

> Looks pretty much done to my eye, thanks again for all your efforts! > > > > Just some minor consistency issues below: Hey! I'll fix the last comments...

Hey! I didn't forget the PR 😉. I'm planning to work on it tomorrow between launch.

Hey ! Just wanted to validate the fix with `AdGuard Home`. Having the default rate limit times out random requests made by `glance` when a lot of services are monitored....

> Hey @DataHearth ! Sorry for missing this. > > Are you still available to make this work? > > If you have questions, please join our Discord: https://discord.gg/Zh2D7mgr Hey!...

I can potentially create the python binding using either [PyO3](https://github.com/PyO3/pyo3) or ~~[RustPython](https://github.com/RustPython/RustPython)~~ if you're ok with that 🙂 . EDIT: I think PyO3 would be a better choice if we...