system-tests
system-tests copied to clipboard
Separate DD_TRACE_CLIENT_IP headers into different scenarios
trafficstars
Motivation
The Test_Config_ClientIPHeader_Precedence test class, which tests the http client IP tag based on a list of "default" headers, was failing due to a client IP header being specified in the DD_TRACE_CLIENT_IP_HEADER env var.
Changes
To avoid conflict, I moved DD_TRACE_CLIENT_IP_HEADER into a different scenario, tracing_config_nondefault_2
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
codeownersfile quickly. - Framework is modified, or non obvious usage of it -> get a review from R&P team
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
:rocket: Once your PR is reviewed, you can merge it!
Reviewer checklist
- [ ] If PR title starts with
[<language>], double-check that only<language>is impacted by the change - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-imagelabel is present
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team