system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

[WIP] Enable Config Consistency tests for Golang

Open mtoffl01 opened this issue 1 year ago • 0 comments

Motivation

Config Consistency effort

Changes

  • Enables various tests in golang.yml that are already supported in dd-trace-go (most are marked with 1.67.0 which was the current version at the time of testing; one other is marked with v1.62.0 which is the version that contained a fix specific to the test)
  • Enables various tests in golang.yml that will be supported in upcoming dd-trace-go release v1.69.0, thanks to this PR
  • Improves system-test execution documentation for Go
  • Amends Test_Config_TraceAgentURL test class to support how dd-trace-go formats trace_agent_url in startup log
  • Modifies /make_distant_call endpoint to return a response in JSON format
  • Updates Go parametric app's GetTraceConfig logic to include trace rate limit and trace agent URL info in HTTP response

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

mtoffl01 avatar Sep 16 '24 18:09 mtoffl01