system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

[parametric] Enable OTEL Env parametric tests for Java

Open zacharycmontoya opened this issue 1 year ago • 0 comments
trafficstars

Motivation

Ensures that all languages that have implemented the OpenTelemetry environment variable mapping feature are running the corresponding system-tests.

Changes

Enables test cases in parametric/test_otel_env_vars.py for Java. This required adding special mappings for propagation style names and setting DD_TRACE_OTEL_ENABLED=true in all test cases to run the Java code.

Since the tests require a new GetTraceConfig endpoint, this was implemented as part of this commit. Note that there's an obscene amount of reflection to get the required tracer settings from the internal config object. Any and all feedback is welcome to improve the maintainability of this endpoint.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

zacharycmontoya avatar Jul 23 '24 01:07 zacharycmontoya