system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Initial setup for trace stats test

Open ajgajg1134 opened this issue 1 year ago • 3 comments
trafficstars

Motivation

As part of building confidence for enabling client side stats by default this builds out some initial system tests to verify that client stats can be enabled and properly emit the expected stats.

So far this is a limited set of tests as the actual behavior is not implemented in most languages (at least not with all the requisite features like peer tags aggregation). The weblog for golang and python has been updated here, but only go is enabled for now as we determine why the python stats are inconsistently packaged.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

ajgajg1134 avatar Jul 09 '24 20:07 ajgajg1134