system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

K8s lib injection: Test ASM and PROFILING features

Open robertomonteromiguel opened this issue 1 year ago • 0 comments

Motivation

Allow deployment of the real agent on the k8s cluster. Testing ASM and PROFILING features activation using the datadog cluster admission controller. The test workflow is:

  • Deploy datadog cluster and activate admission controller. Append the custom features activation (ie: ASM or profiling)
  • Deploy datadog real agent
  • Deploy sample application (weblog) as pod (we can add custom env vars, ie: DD_PROFILING_UPLOAD_PERIOD)
  • Test assertions: Validate backend trace_id (assertions are the same as host and container autoinstrumentation tests [onboarding tests])

Check the tests: https://github.com/DataDog/system-tests/pull/2691/files#diff-4e15c0acbc4e136c7106e35867c65ba47fd652f3eb5abfa800249e583dbfc2f8R68

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

robertomonteromiguel avatar Jul 08 '24 09:07 robertomonteromiguel