system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Add a test for conflicts in auto-user-instrum

Open manuel-alvarez-alvarez opened this issue 1 year ago • 2 comments

Motivation

Check the behavior of the tracers when conflicting remote config payloads are received from the agent in regards to auto user instrumentation.

Changes

Add new config files to the test triggering a conflict in the configuration of auto user instrumentation.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
  • [ ] A scenario is added (or removed)?

manuel-alvarez-alvarez avatar Jun 26 '24 09:06 manuel-alvarez-alvarez

./format.sh :)

Oops! sorry for that, my bad!, formatted :smile:

manuel-alvarez-alvarez avatar Jun 27 '24 09:06 manuel-alvarez-alvarez

your PR isn't an PR to main, do you still need a review ?

Nope, we are still discussing internally if we want to have this kind of unspecified behavior tested (That's why I splited the PR in two). I've converted it to draft so it does not introduce noise for you.

manuel-alvarez-alvarez avatar Jun 28 '24 08:06 manuel-alvarez-alvarez

No longer needed

manuel-alvarez-alvarez avatar Aug 13 '24 08:08 manuel-alvarez-alvarez