system-tests
system-tests copied to clipboard
Enable the install signature system test for Ruby
Motivation
This one-liner is a follow-up PR on top of https://github.com/DataDog/system-tests/pull/1823 . Now that Ruby has implemented install signatures in v1.19.0, we no longer need to mark install signature as a missing feature for Ruby.
Changes
See above. This can be tested with
cd ~/dd/system-tests/
./build.sh
TEST_LIBRARY=ruby ./run.sh -r PARAMETRIC tests/parametric/test_telemetry.py
Workflow
- ⚠️ Create your PR as draft ⚠️
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
codeownersfile quickly. - Framework is modified, or non obvious usage of it -> get a review from R&P team
- Test logic is modified? -> Get a review from RFC owner. We're working on refining the
:rocket: Once your PR is reviewed, you can merge it!
Reviewer checklist
- [ ] Relevant label (
run-parametric-scenario,run-profiling-scenario...) are presents - [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
- [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] A docker base image is modified?
- [ ] the relevant
build-XXX-imagelabel is present - [ ] To R&P team: locally build and push the image to hub.docker.com
- [ ] the relevant
- [ ] A scenario is added (or removed)?
- [ ] Get a review from R&P team
- [ ] Once merged, add (or remove) it in system-test-dasboard nightly