system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

python: enable support for opentelemetry api

Open majorgreys opened this issue 2 years ago • 3 comments
trafficstars

Description

This enables Python support for opentelemetry api tests covering reserved span attributes and operation name.

  • https://github.com/DataDog/dd-trace-py/pull/7587
  • https://github.com/DataDog/dd-trace-py/pull/7619

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:

Reviewer checklist

  • [ ] Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • [ ] CI is green
    • [ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • [ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

majorgreys avatar Nov 15 '23 16:11 majorgreys

@robertomonteromiguel I am not sure if the tests here are run against the default branch of the dd-trace-py repo or the latest released version. Is it the latter?

majorgreys avatar Nov 17 '23 16:11 majorgreys

@robertomonteromiguel I am not sure if the tests here are run against the default branch of the dd-trace-py repo or the latest released version. Is it the latter?

The tests should be run agains the latest release.

  • https://github.com/DataDog/system-tests/blob/2f3206ecee5bef0f2ee016925b7af910064978c8/tests/parametric/conftest.py#L101
  • https://github.com/DataDog/system-tests/blob/main/docs/scenarios/parametric.md#python
  • https://github.com/DataDog/system-tests/blob/main/utils/build/docker/python/parametric/ddtracer_version.Dockerfile

robertomonteromiguel avatar Nov 20 '23 08:11 robertomonteromiguel

Hi @majorgreys, do you still plan to work on this ?

cbeauchesne avatar Sep 05 '24 15:09 cbeauchesne