system-tests
system-tests copied to clipboard
Fix node.js parametric resource name, service name, and span type setting
Description
The Node.js gRPC client was not correctly setting the resource name, service name, or span type from test_library.start_span("operation", service="service", resource="resource", typestr="web").
This change properly sets the required "resource.name", "service.name", and "span.type" tags.
Motivation
Resource name, service name, and span type was not being set properly.
Workflow
- ⚠️⚠️ Create your PR as draft
- Follow the style guidelines of this project (See how to easily lint the code)
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist
- [ ] Check what scenarios are modified. If needed, add the relevant label (
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info). - [ ] CI is green
- [ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] if any of
build-some-imagelabel is present- is the image labl have been updated ?
- just before merging, locally build and push the image to hub.docker.com
- [ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly
The CI is failing on nodejs/parametric, is it related to your change ?
https://github.com/DataDog/system-tests/actions/runs/5931092747/job/16082300821?pr=1519
Yes, I fixed the client, but then tests which are currently passing are starting to fail. Needs someone to investigate.
Hi @brettlangdon, do you still plan to work on this ?