libdatadog icon indicating copy to clipboard operation
libdatadog copied to clipboard

Use serde_bytes for meta_struct

Open bwoebi opened this issue 1 year ago • 2 comments
trafficstars

Otherwise meta_struct will be serialized as an array of integers instead of a byte string, breaking the expected representation.

Appsec is trying to use it, but breaking when using the sidecar trace sender.

bwoebi avatar Jul 19 '24 12:07 bwoebi

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (d351d66) to head (3ae1507).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files         206      206           
  Lines       28129    28129           
=======================================
  Hits        19856    19856           
  Misses       8273     8273           
Components Coverage Δ
crashtracker 16.52% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 75.29% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.78% <ø> (ø)
profiling-ffi 58.64% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 71.14% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 69.83% <0.00%> (-7.33%) :arrow_down:
trace-utils 91.63% <ø> (+0.59%) :arrow_up:

codecov-commenter avatar Jul 19 '24 13:07 codecov-commenter

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

pr-commenter[bot] avatar Jul 19 '24 13:07 pr-commenter[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To override this behavior, add the keep-open label or update the PR.

github-actions[bot] avatar Nov 01 '24 00:11 github-actions[bot]