libdatadog
libdatadog copied to clipboard
Allow to extend Endpoint path
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
Benchmarks
Comparison
Benchmark execution time: 2025-04-15 14:43:36
Comparing candidate commit c2c152ab in PR branch vianney/ddcommon/add-path-to-endpoint with baseline commit b862c477 in branch main.
Found 1 performance improvements and 10 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.
scenario:benching deserializing traces from msgpack to their internal representation
- 🟩
execution_time[-15.445ms; -15.351ms] or [-21.207%; -21.077%]
scenario:credit_card/is_card_number/ 3782-8224-6310-005
- 🟥
execution_time[+4.719µs; +4.852µs] or [+6.087%; +6.258%] - 🟥
throughput[-760986.922op/s; -739439.229op/s] or [-5.900%; -5.733%]
scenario:credit_card/is_card_number/ 378282246310005
- 🟥
execution_time[+5.739µs; +5.851µs] or [+8.048%; +8.205%] - 🟥
throughput[-1063792.732op/s; -1043785.556op/s] or [-7.586%; -7.444%]
scenario:credit_card/is_card_number/378282246310005
- 🟥
execution_time[+5.813µs; +5.960µs] or [+8.574%; +8.791%] - 🟥
throughput[-1193115.654op/s; -1163494.281op/s] or [-8.089%; -7.889%]
scenario:credit_card/is_card_number/x371413321323331
- 🟥
execution_time[+529.346ns; +549.299ns] or [+8.735%; +9.065%] - 🟥
throughput[-13711161.308op/s; -13239541.605op/s] or [-8.308%; -8.023%]
scenario:credit_card/is_card_number_no_luhn/x371413321323331
- 🟥
execution_time[+526.324ns; +543.953ns] or [+8.686%; +8.976%] - 🟥
throughput[-13590409.284op/s; -13173274.594op/s] or [-8.235%; -7.983%]
Candidate
Candidate benchmark details
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 57.035ms | 57.432ms ± 0.258ms | 57.373ms ± 0.134ms | 57.560ms | 57.903ms | 58.123ms | 58.952ms | 2.75% | 1.666 | 5.342 | 0.45% | 0.018ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [57.396ms; 57.468ms] or [-0.062%; +0.062%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 504.118µs | 505.164µs ± 0.444µs | 505.147µs ± 0.258µs | 505.398µs | 505.875µs | 506.062µs | 508.202µs | 0.60% | 1.600 | 9.713 | 0.09% | 0.031µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 1967720.851op/s | 1979556.882op/s ± 1735.535op/s | 1979623.515op/s ± 1009.852op/s | 1980660.883op/s | 1981988.700op/s | 1982940.276op/s | 1983663.648op/s | 0.20% | -1.576 | 9.525 | 0.09% | 122.721op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 453.581µs | 455.162µs ± 0.525µs | 455.090µs ± 0.319µs | 455.517µs | 456.156µs | 456.287µs | 456.527µs | 0.32% | 0.122 | 0.092 | 0.12% | 0.037µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2190450.228op/s | 2197021.394op/s ± 2535.886op/s | 2197369.606op/s ± 1539.417op/s | 2198686.323op/s | 2200715.122op/s | 2203124.668op/s | 2204679.830op/s | 0.33% | -0.115 | 0.096 | 0.12% | 179.314op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 177.506µs | 177.795µs ± 0.113µs | 177.788µs ± 0.069µs | 177.860µs | 177.979µs | 178.073µs | 178.177µs | 0.22% | 0.178 | 0.338 | 0.06% | 0.008µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5612408.186op/s | 5624454.079op/s ± 3584.402op/s | 5624663.078op/s ± 2172.206op/s | 5626795.900op/s | 5630432.064op/s | 5632393.990op/s | 5633626.319op/s | 0.16% | -0.174 | 0.336 | 0.06% | 253.455op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 37.522µs | 37.635µs ± 0.041µs | 37.628µs ± 0.028µs | 37.665µs | 37.706µs | 37.743µs | 37.753µs | 0.33% | 0.429 | -0.080 | 0.11% | 0.003µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26488076.176op/s | 26571316.567op/s ± 28824.759op/s | 26576043.859op/s ± 20098.915op/s | 26591043.943op/s | 26611164.698op/s | 26624755.271op/s | 26651003.305op/s | 0.28% | -0.423 | -0.085 | 0.11% | 2038.218op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 48.085µs | 48.292µs ± 0.235µs | 48.140µs ± 0.053µs | 48.508µs | 48.625µs | 48.743µs | 49.648µs | 3.13% | 1.284 | 3.677 | 0.49% | 0.017µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 20141731.388op/s | 20707696.650op/s ± 100172.570op/s | 20772580.331op/s ± 23006.252op/s | 20792557.453op/s | 20795375.109op/s | 20795896.863op/s | 20796306.576op/s | 0.11% | -1.228 | 3.243 | 0.48% | 7083.270op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [505.102µs; 505.225µs] or [-0.012%; +0.012%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [1979316.353op/s; 1979797.410op/s] or [-0.012%; +0.012%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [455.089µs; 455.235µs] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2196669.945op/s; 2197372.844op/s] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [177.779µs; 177.811µs] or [-0.009%; +0.009%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5623957.315op/s; 5624950.842op/s] or [-0.009%; +0.009%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.629µs; 37.640µs] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [26567321.733op/s; 26575311.401op/s] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [48.260µs; 48.325µs] or [-0.067%; +0.067%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [20693813.696op/s; 20721579.605op/s] or [-0.067%; +0.067%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 17.635µs | 26.025µs ± 11.320µs | 17.823µs ± 0.151µs | 35.729µs | 46.058µs | 48.185µs | 89.751µs | 403.56% | 1.613 | 4.570 | 43.39% | 0.800µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [24.456µs; 27.594µs] or [-6.028%; +6.028%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.897µs | 3.915µs ± 0.003µs | 3.915µs ± 0.002µs | 3.916µs | 3.919µs | 3.920µs | 3.922µs | 0.18% | -1.363 | 8.784 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254976149.854op/s | 255453892.676op/s ± 176657.152op/s | 255447446.785op/s ± 100649.852op/s | 255552575.832op/s | 255731121.038op/s | 255858706.436op/s | 256624032.539op/s | 0.46% | 1.381 | 8.911 | 0.07% | 12491.547op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 81.963µs | 82.314µs ± 0.211µs | 82.253µs ± 0.106µs | 82.424µs | 82.727µs | 82.968µs | 83.369µs | 1.36% | 1.538 | 3.536 | 0.26% | 0.015µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 11994828.459op/s | 12148741.003op/s ± 30960.807op/s | 12157541.004op/s ± 15630.363op/s | 12170919.110op/s | 12182894.792op/s | 12188109.962op/s | 12200638.093op/s | 0.35% | -1.514 | 3.407 | 0.25% | 2189.260op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 76.344µs | 77.110µs ± 0.327µs | 77.100µs ± 0.223µs | 77.319µs | 77.652µs | 77.991µs | 78.125µs | 1.33% | 0.411 | 0.041 | 0.42% | 0.023µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 12799977.315op/s | 12968710.369op/s ± 54948.299op/s | 12970179.090op/s ± 37576.358op/s | 13007587.028op/s | 13050251.631op/s | 13073809.987op/s | 13098542.958op/s | 0.99% | -0.387 | 0.010 | 0.42% | 3885.432op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.890µs | 3.914µs ± 0.003µs | 3.914µs ± 0.002µs | 3.915µs | 3.918µs | 3.921µs | 3.928µs | 0.37% | -1.296 | 12.748 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254557145.788op/s | 255519687.425op/s ± 215678.221op/s | 255501903.490op/s ± 102547.864op/s | 255624936.699op/s | 255800951.193op/s | 255932059.712op/s | 257042822.429op/s | 0.60% | 1.329 | 12.939 | 0.08% | 15250.753op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 72.839µs | 73.690µs ± 0.378µs | 73.690µs ± 0.280µs | 73.957µs | 74.315µs | 74.510µs | 74.541µs | 1.15% | 0.032 | -0.614 | 0.51% | 0.027µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 13415385.514op/s | 13570747.754op/s ± 69622.379op/s | 13570279.731op/s ± 51499.570op/s | 13624187.019op/s | 13681318.544op/s | 13707998.345op/s | 13728890.947op/s | 1.17% | -0.011 | -0.616 | 0.51% | 4923.046op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 51.916µs | 52.129µs ± 0.080µs | 52.135µs ± 0.057µs | 52.184µs | 52.250µs | 52.303µs | 52.330µs | 0.37% | -0.141 | -0.410 | 0.15% | 0.006µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 19109541.165op/s | 19183387.471op/s ± 29511.456op/s | 19180894.870op/s ± 20899.538op/s | 19201984.525op/s | 19234968.028op/s | 19246686.050op/s | 19261919.366op/s | 0.42% | 0.148 | -0.408 | 0.15% | 2086.775op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.436µs | 6.599µs ± 0.066µs | 6.597µs ± 0.043µs | 6.640µs | 6.710µs | 6.732µs | 6.762µs | 2.50% | 0.134 | -0.617 | 1.00% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 147886960.053op/s | 151551373.881op/s ± 1515856.238op/s | 151590291.390op/s ± 1003080.344op/s | 152598566.537op/s | 153882106.620op/s | 154422436.901op/s | 155376265.075op/s | 2.50% | -0.093 | -0.624 | 1.00% | 107187.223op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.895µs | 3.914µs ± 0.003µs | 3.914µs ± 0.002µs | 3.916µs | 3.919µs | 3.920µs | 3.920µs | 0.16% | -1.557 | 9.826 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 255076531.941op/s | 255490143.280op/s ± 187116.032op/s | 255486781.038op/s ± 105277.895op/s | 255592677.272op/s | 255741961.085op/s | 255913538.341op/s | 256768321.540op/s | 0.50% | 1.578 | 9.982 | 0.07% | 13231.101op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 63.792µs | 63.972µs ± 0.094µs | 63.954µs ± 0.051µs | 64.020µs | 64.150µs | 64.233µs | 64.387µs | 0.68% | 1.005 | 1.704 | 0.15% | 0.007µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15530987.139op/s | 15631822.409op/s ± 22980.938op/s | 15636252.571op/s ± 12487.633op/s | 15646894.831op/s | 15662797.332op/s | 15673811.352op/s | 15675998.479op/s | 0.25% | -0.994 | 1.661 | 0.15% | 1624.998op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 57.749µs | 57.853µs ± 0.063µs | 57.847µs ± 0.026µs | 57.872µs | 57.946µs | 58.135µs | 58.172µs | 0.56% | 2.000 | 7.275 | 0.11% | 0.004µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 17190499.953op/s | 17285061.737op/s ± 18701.916op/s | 17286937.126op/s ± 7657.573op/s | 17295040.215op/s | 17310736.208op/s | 17315160.670op/s | 17316291.167op/s | 0.17% | -1.983 | 7.183 | 0.11% | 1322.425op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.896µs | 3.915µs ± 0.003µs | 3.914µs ± 0.002µs | 3.917µs | 3.920µs | 3.922µs | 3.923µs | 0.24% | -0.523 | 3.716 | 0.09% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254894650.694op/s | 255459213.387op/s ± 223739.977op/s | 255503053.262op/s ± 107120.740op/s | 255580360.861op/s | 255812841.198op/s | 255893352.282op/s | 256691149.611op/s | 0.47% | 0.537 | 3.785 | 0.09% | 15820.805op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 54.548µs | 54.708µs ± 0.134µs | 54.673µs ± 0.033µs | 54.708µs | 55.075µs | 55.163µs | 55.305µs | 1.15% | 2.458 | 5.809 | 0.24% | 0.009µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 18081579.939op/s | 18278915.318op/s ± 44463.524op/s | 18290399.372op/s ± 10991.125op/s | 18300582.416op/s | 18317980.017op/s | 18326862.452op/s | 18332639.431op/s | 0.23% | -2.445 | 5.742 | 0.24% | 3144.046op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 51.952µs | 52.152µs ± 0.075µs | 52.162µs ± 0.049µs | 52.201µs | 52.261µs | 52.307µs | 52.360µs | 0.38% | -0.308 | 0.018 | 0.14% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 19098567.508op/s | 19174717.134op/s ± 27589.656op/s | 19170909.104op/s ± 18028.988op/s | 19193215.678op/s | 19231314.157op/s | 19240107.540op/s | 19248463.782op/s | 0.40% | 0.316 | 0.021 | 0.14% | 1950.883op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.443µs | 6.595µs ± 0.058µs | 6.592µs ± 0.040µs | 6.633µs | 6.693µs | 6.743µs | 6.783µs | 2.89% | 0.305 | 0.143 | 0.88% | 0.004µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 147430531.871op/s | 151644274.434op/s ± 1336755.958op/s | 151690066.068op/s ± 919110.323op/s | 152575188.308op/s | 153672277.688op/s | 154354610.987op/s | 155205135.939op/s | 2.32% | -0.251 | 0.089 | 0.88% | 94522.920op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.914µs; 3.915µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255429409.694op/s; 255478375.658op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [82.284µs; 82.343µs] or [-0.035%; +0.035%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12144450.133op/s; 12153031.873op/s] or [-0.035%; +0.035%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [77.065µs; 77.155µs] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [12961095.063op/s; 12976325.675op/s] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.913µs; 3.914µs] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255489796.498op/s; 255549578.352op/s] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [73.637µs; 73.742µs] or [-0.071%; +0.071%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [13561098.762op/s; 13580396.746op/s] or [-0.071%; +0.071%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [52.117µs; 52.140µs] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [19179297.467op/s; 19187477.475op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.590µs; 6.608µs] or [-0.139%; +0.139%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [151341290.786op/s; 151761456.977op/s] or [-0.139%; +0.139%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.914µs; 3.914µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255464210.797op/s; 255516075.762op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [63.959µs; 63.985µs] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15628637.472op/s; 15635007.346op/s] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [57.845µs; 57.862µs] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [17282469.831op/s; 17287653.642op/s] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.914µs; 3.915µs] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255428205.178op/s; 255490221.596op/s] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [54.690µs; 54.727µs] or [-0.034%; +0.034%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [18272753.101op/s; 18285077.535op/s] or [-0.034%; +0.034%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [52.142µs; 52.163µs] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [19170893.473op/s; 19178540.795op/s] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.587µs; 6.603µs] or [-0.122%; +0.122%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [151459012.915op/s; 151829535.954op/s] or [-0.122%; +0.122%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 6.017ms | 6.030ms ± 0.016ms | 6.028ms ± 0.003ms | 6.032ms | 6.039ms | 6.078ms | 6.219ms | 3.18% | 8.971 | 97.795 | 0.27% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [6.028ms; 6.032ms] or [-0.037%; +0.037%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 4.918µs | 5.009µs ± 0.050µs | 5.033µs ± 0.038µs | 5.054µs | 5.071µs | 5.075µs | 5.081µs | 0.95% | -0.274 | -1.540 | 1.01% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.002µs; 5.016µs] or [-0.140%; +0.140%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 208.896µs | 209.210µs ± 0.156µs | 209.187µs ± 0.090µs | 209.300µs | 209.503µs | 209.699µs | 209.862µs | 0.32% | 0.934 | 1.514 | 0.07% | 0.011µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 4765044.901op/s | 4779881.541op/s ± 3572.296op/s | 4780405.437op/s ± 2062.109op/s | 4782215.260op/s | 4784333.989op/s | 4786126.634op/s | 4787076.171op/s | 0.14% | -0.928 | 1.494 | 0.07% | 252.600op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 18.635µs | 18.698µs ± 0.036µs | 18.694µs ± 0.014µs | 18.710µs | 18.752µs | 18.798µs | 18.992µs | 1.59% | 3.200 | 22.663 | 0.19% | 0.003µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 52654641.774op/s | 53483017.184op/s ± 101170.217op/s | 53494287.672op/s ± 41316.307op/s | 53530470.650op/s | 53628965.278op/s | 53649841.948op/s | 53661657.791op/s | 0.31% | -3.119 | 21.821 | 0.19% | 7153.815op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.838µs | 10.930µs ± 0.054µs | 10.918µs ± 0.040µs | 10.963µs | 11.027µs | 11.054µs | 11.107µs | 1.73% | 0.619 | -0.233 | 0.50% | 0.004µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 90032127.618op/s | 91494551.959op/s ± 453763.959op/s | 91589414.574op/s ± 333935.674op/s | 91861901.181op/s | 92084377.994op/s | 92173285.800op/s | 92266047.017op/s | 0.74% | -0.599 | -0.273 | 0.49% | 32085.957op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [209.189µs; 209.232µs] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [4779386.456op/s; 4780376.627op/s] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [18.693µs; 18.703µs] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [53468995.965op/s; 53497038.403op/s] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.922µs; 10.937µs] or [-0.069%; +0.069%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [91431664.639op/s; 91557439.280op/s] or [-0.069%; +0.069%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 32.683µs | 33.184µs ± 0.828µs | 32.797µs ± 0.068µs | 32.965µs | 34.894µs | 34.928µs | 36.908µs | 12.53% | 1.836 | 2.126 | 2.49% | 0.059µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [33.069µs; 33.299µs] or [-0.346%; +0.346%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 67.596µs | 67.805µs ± 0.222µs | 67.779µs ± 0.038µs | 67.817µs | 67.963µs | 68.338µs | 70.516µs | 4.04% | 9.592 | 110.466 | 0.33% | 0.016µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [67.774µs; 67.836µs] or [-0.045%; +0.045%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 146.927µs | 147.704µs ± 0.383µs | 147.651µs ± 0.184µs | 147.846µs | 148.263µs | 149.188µs | 150.637µs | 2.02% | 3.138 | 18.348 | 0.26% | 0.027µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [147.651µs; 147.757µs] or [-0.036%; +0.036%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.176µs | 3.217µs ± 1.441µs | 3.024µs ± 0.035µs | 3.050µs | 3.670µs | 14.035µs | 15.047µs | 397.63% | 7.396 | 55.637 | 44.67% | 0.102µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [3.017µs; 3.417µs] or [-6.206%; +6.206%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 243.700ns | 254.175ns ± 12.659ns | 248.230ns ± 2.190ns | 253.239ns | 279.052ns | 293.088ns | 293.538ns | 18.25% | 1.764 | 1.903 | 4.97% | 0.895ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [252.420ns; 255.929ns] or [-0.690%; +0.690%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | c2c152ab | 1744727018 | vianney/ddcommon/add-path-to-endpoint |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.393µs | 2.423µs ± 0.024µs | 2.416µs ± 0.007µs | 2.425µs | 2.498µs | 2.504µs | 2.508µs | 3.79% | 2.281 | 4.869 | 1.00% | 0.002µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.420µs; 2.426µs] or [-0.138%; +0.138%] | None | None | None |
Baseline
Omitted due to size.
Codecov Report
Attention: Patch coverage is 85.41667% with 14 lines in your changes missing coverage. Please review.
Project coverage is 71.55%. Comparing base (
a0b92b6) to head (c2c152a). Report is 11 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 71.48% 71.55% +0.07%
==========================================
Files 337 339 +2
Lines 50509 50727 +218
==========================================
+ Hits 36104 36298 +194
- Misses 14405 14429 +24
| Components | Coverage Δ | |
|---|---|---|
| crashtracker | 42.82% <ø> (+0.15%) |
:arrow_up: |
| crashtracker-ffi | 6.30% <ø> (ø) |
|
| datadog-alloc | 98.73% <ø> (ø) |
|
| data-pipeline | 90.87% <77.77%> (+0.13%) |
:arrow_up: |
| data-pipeline-ffi | 90.35% <ø> (ø) |
|
| ddcommon | 78.80% <95.23%> (-1.15%) |
:arrow_down: |
| ddcommon-ffi | 66.37% <ø> (ø) |
|
| ddtelemetry | 60.29% <ø> (+0.01%) |
:arrow_up: |
| ddtelemetry-ffi | 21.43% <ø> (ø) |
|
| dogstatsd-client | 82.57% <ø> (ø) |
|
| ipc | 82.41% <ø> (-0.11%) |
:arrow_down: |
| profiling | 77.57% <ø> (ø) |
|
| profiling-ffi | 62.28% <ø> (ø) |
|
| serverless | 0.00% <ø> (ø) |
|
| sidecar | 41.14% <ø> (+0.18%) |
:arrow_up: |
| sidecar-ffi | 2.05% <ø> (+1.47%) |
:arrow_up: |
| spawn-worker | 54.37% <ø> (ø) |
|
| tinybytes | 89.86% <ø> (-1.74%) |
:arrow_down: |
| trace-mini-agent | 73.82% <ø> (ø) |
|
| trace-normalization | 98.24% <ø> (ø) |
|
| trace-obfuscation | 96.00% <ø> (ø) |
|
| trace-protobuf | 78.50% <ø> (ø) |
|
| trace-utils | 92.82% <ø> (-0.23%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Artifact Size Benchmark Report
aarch64-alpine-linux-musl
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug | 23.99 MB | 23.99 MB | +0% (+672 B) 👌 |
| /aarch64-alpine-linux-musl/lib/libdatadog_profiling.a | 77.63 MB | 77.65 MB | +.01% (+13.11 KB) 🔍 |
| /aarch64-alpine-linux-musl/lib/libdatadog_profiling.so | 7.78 MB | 7.78 MB | +.01% (+840 B) 🔍 |
aarch64-unknown-linux-gnu
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug | 22.56 MB | 22.56 MB | +0% (+1.35 KB) 👌 |
| /aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so | 7.71 MB | 7.71 MB | +.01% (+872 B) 🔍 |
| /aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a | 71.86 MB | 71.88 MB | +.02% (+15.32 KB) 🔍 |
libdatadog-x64-windows
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll | 16.85 MB | 16.86 MB | +.04% (+8.00 KB) 🔍 |
| /libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib | 61.83 KB | 61.83 KB | 0% (0 B) 👌 |
| /libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb | 113.05 MB | 113.08 MB | +.03% (+40.00 KB) 🔍 |
| /libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib | 630.61 MB | 631.00 MB | +.06% (+402.12 KB) 🔍 |
| /libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll | 5.04 MB | 5.04 MB | +.04% (+2.50 KB) 🔍 |
| /libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib | 61.83 KB | 61.83 KB | 0% (0 B) 👌 |
| /libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb | 16.06 MB | 16.06 MB | 0% (0 B) 👌 |
| /libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib | 26.71 MB | 26.72 MB | +.02% (+6.05 KB) 🔍 |
libdatadog-x86-windows
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll | 14.25 MB | 14.26 MB | +.04% (+6.50 KB) 🔍 |
| /libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib | 62.78 KB | 62.78 KB | 0% (0 B) 👌 |
| /libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb | 115.03 MB | 115.06 MB | +.02% (+32.00 KB) 🔍 |
| /libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib | 622.55 MB | 622.48 MB | --.01% (-67.19 KB) 💪 |
| /libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll | 3.81 MB | 3.81 MB | +.05% (+2.00 KB) 🔍 |
| /libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib | 62.78 KB | 62.78 KB | 0% (0 B) 👌 |
| /libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb | 16.68 MB | 16.68 MB | 0% (0 B) 👌 |
| /libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib | 24.61 MB | 24.62 MB | +.05% (+12.66 KB) 🔍 |
x86_64-alpine-linux-musl
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /x86_64-alpine-linux-musl/lib/libdatadog_profiling.a | 66.92 MB | 66.94 MB | +.02% (+16.57 KB) 🔍 |
| /x86_64-alpine-linux-musl/lib/libdatadog_profiling.so | 8.25 MB | 8.25 MB | +0% (+544 B) 👌 |
| /x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug | 23.15 MB | 23.15 MB | +0% (+2.26 KB) 👌 |
x86_64-unknown-linux-gnu
| Artifact | Baseline | Commit | Change |
|---|---|---|---|
| /x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a | 67.84 MB | 67.86 MB | +.02% (+16.71 KB) 🔍 |
| /x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so | 8.13 MB | 8.13 MB | +0% (+544 B) 👌 |
| /x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug | 20.77 MB | 20.78 MB | +.01% (+2.78 KB) 🔍 |
I'm not entirely sure what you are after, since there's no elaboration beyond the title. The endpoint is roughly a scheme and authority. I think it wasn't meant to be a generic URL. It's basically "this is the server you talk to and how" but it doesn't know about URL paths and such.
I'm not rejecting your PR, just trying to have a discussion about what the goal is.
This is mostly a mix of several ideas and some experimentations. One thing I was trying to solve is to avoid recreating the endpoint when accessing a specific path (e.g. /v04/traces). There should be an easy way to send a request to a specific route of a server described by an endpoint.
There should be an easy way to send a request to a specific route of a server described by an endpoint.
What API are you using to make the HTTP request?