integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

test

Open kozlovb opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

test if ci is broken, I am not doing a draft cause I dont remember if draft would start tests

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

kozlovb avatar Jun 17 '24 12:06 kozlovb

@itstauq Since the DistributedProjects uses the same objects inside it, I was wondering if this is a better fix as long as we run it by PM. It changes the Request object for the single projects too but it's just a change to the repr so not a conflicting change IMO.

snwagh avatar Jun 27 '24 18:06 snwagh

@itstauq To address your comment, added another commit that does not create a breaking change.

snwagh avatar Jun 28 '24 17:06 snwagh

Closing for now, we will move the domain information to Project code in this PR: https://github.com/OpenMined/PySyft/pull/8999

madhavajay avatar Jul 02 '24 04:07 madhavajay