go-python3 icon indicating copy to clipboard operation
go-python3 copied to clipboard

PyEval_ReInitThreads removed since python 3.8

Open wujunfeng1 opened this issue 4 years ago • 2 comments

Describe what happened: PyEval_ReInitThreads() uses C.PyEval_ReInitThreads, but this symbol has been removed since python3.8.

Describe what you expected: Please revise the code to check whether symbol C.PyEval_ReInitThreads exists. If not, just skip using this symbol in PyEval_ReInitThreads().

Steps to reproduce the issue: With python 3.8, get go-python3 package.

wujunfeng1 avatar Feb 02 '21 00:02 wujunfeng1

just in case that it helps, I've done this for Python 3.8 here for my own use. Some more has to be removed for Python 3.9.

christian-korneck avatar Feb 02 '21 00:02 christian-korneck

Thanks.

Christian Korneck [email protected] 于2021年2月2日周二 上午11:46写道:

just in case that it helps, I've done this for Python 3.8 here https://github.com/christian-korneck/go-python3/commit/6f8fd23d06e2fa4720e79df61d86f3b694061636 for my own use. Some more has to be removed for Python 3.9.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DataDog/go-python3/issues/39#issuecomment-771264731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOH4OEF6KIJKAE7XIOCK2X3S45DQHANCNFSM4W5W35DQ .

wujunfeng1 avatar Feb 02 '21 23:02 wujunfeng1