dd-trace-rb
dd-trace-rb copied to clipboard
DEBUG-2334 dynamic instrumentation probe notification builder
Change log entry
None, DI is not customer-visible at this time.
What does this PR do?
This PR adds a component to create status and snapshot payloads for probes.
Motivation:
Initial DI implementation in Ruby.
Additional Notes:
Most of the test coverage is in integration tests for DI overall. This PR has minimal test coverage.
Correctness of generated payloads is meant to ultimately be verified by system tests.
How to test the change?
Unsure? Have a question? Request a review!
Codecov Report
Attention: Patch coverage is 96.13260% with 7 lines in your changes missing coverage. Please review.
Project coverage is 97.84%. Comparing base (
321f513) to head (0080237). Report is 5 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/datadog/di/probe_notification_builder.rb | 92.10% | 6 Missing :warning: |
| .../di/integration/probe_notification_builder_spec.rb | 98.07% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4011 +/- ##
==========================================
- Coverage 97.86% 97.84% -0.02%
==========================================
Files 1321 1324 +3
Lines 79330 79511 +181
Branches 3934 3956 +22
==========================================
+ Hits 77635 77797 +162
- Misses 1695 1714 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Benchmarks
Benchmark execution time: 2024-10-25 18:02:49
Comparing candidate commit 00802374ea61c41191e3157aad250e670fd2bfa6 in PR branch di-probe-notification-builder with baseline commit 321f513e864b77489b3a5d3a8cc8db7f2e1d7fc8 in branch master.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.
scenario:profiler - sample timeline=false
- 🟩
throughput[+0.525op/s; +0.537op/s] or [+8.413%; +8.599%]