dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Integrate catadog image as proxy service between agent and library

Open sarahchen6 opened this issue 1 year ago • 3 comments
trafficstars

What does this PR do? This PR integrates the catadog image in the docker-compose.yml as a proxy service between the library and testagent.

Motivation: Catadog is a tool for development, testing, and diagnosis. By integrating catadog, developers can customize the proxy to suit their development needs.

Additional Notes: In the docker-compose.yml, catadog acts as a proxy between the testagent and ddagent so that it can access relevant trace information. However, catadog is not involved in the CircleCI workflow because it is a development, rather than testing, tool.

How to test the change? You can confirm trace information is correctly passed by running the docker-compose.yml and observing catadog, testagent, and ddagent logs through docker logs <container_id>.

Unsure? Have a question? Request a review!

sarahchen6 avatar Sep 26 '24 19:09 sarahchen6

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 97.86%. Comparing base (1f1afc1) to head (68da931). :warning: Report is 2835 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3958      +/-   ##
==========================================
- Coverage   97.87%   97.86%   -0.01%     
==========================================
  Files        1313     1313              
  Lines       78352    78352              
  Branches     3886     3886              
==========================================
- Hits        76684    76681       -3     
- Misses       1668     1671       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Oct 02 '24 19:10 codecov-commenter

Benchmarks

Benchmark execution time: 2024-10-03 14:55:56

Comparing candidate commit 68da931418b74a192711b326ad4a1edbcbd4b5a8 in PR branch sarahchen6/integrate-catadog-as-proxy with baseline commit 9a012ec38b0f765ec264287b7eb9c3449c9408ee in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3323.477op/s; +3420.832op/s] or [+10.990%; +11.312%]

pr-commenter[bot] avatar Oct 03 '24 14:10 pr-commenter[bot]

Hey @sarahchen6 is this still relevant? E.g. should we keep it, close it, something else? ;)

ivoanjo avatar Dec 09 '24 09:12 ivoanjo

@ivoanjo Thanks for the reminder that I only just saw 😞 . This is no longer relevant, so I will close it. We are not using catadog as a proxy.

sarahchen6 avatar Sep 05 '25 19:09 sarahchen6

No worries! Thanks for giving this a stab + helping us keep the open PRs clean :)

ivoanjo avatar Sep 08 '25 08:09 ivoanjo