dd-trace-rb
dd-trace-rb copied to clipboard
Remove default value from `peer.service` tag
Today, the default value of the span tag peer.service does not provide the correct semantics to populated the new Inferred Service dependency experience.
The peer.service tag should only be used as an explicit user override, which is supported today by APM Ruby.
This PR removes the default value of peer.service, while keeping any explicitly values set by configuration (e.g. c.tracing.instrument :pg, peer_service: 'mydb').
If you need to keep the default values of peer.service, you can set the environment variable DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED=true to restore the behavior to before this change.
Benchmarks
Benchmark execution time: 2025-02-14 23:20:53
Comparing candidate commit 6519beaef7e3b54c26d689f256181b3732fa830f in PR branch DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED with baseline commit 92e97fa982780baaab6a5afb282e9c8827075d66 in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.70%. Comparing base (
92e97fa) to head (6519bea). Report is 1041 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3846 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 1355 1355
Lines 83051 83100 +49
Branches 4218 4219 +1
=======================================
+ Hits 81144 81194 +50
+ Misses 1907 1906 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hey folks, is this still a thing we want to push forward?
Hi. I'm using Inferred Service dependency experience in Ruby So I hope to merge&release this PR. Thank you!
Datadog Report
Branch report: DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED
Commit report: 6519bea
Test service: dd-trace-rb
:white_check_mark: 0 Failed, 20591 Passed, 1371 Skipped, 3m 12.92s Total Time