dd-trace-rb
dd-trace-rb copied to clipboard
Add JRuby 9.4 to test matrix
What does this PR do?
- Add JRuby 9.4 into our matrix
- Disable action cable test that are causing
log writing failed. closed streamin CircleCI.
Motivation:
Increase coverage
Additional Notes:
Our test suite was running into RuntimeError: class variable access from toplevel, I can reproduce it from the test suite but not from the below script.
I downgraded to activerecord 6.1 and activerecord-jdbc-adapter 61.0 to mitigate the failure temporarily.
puts RUBY_DESCRIPTION
require 'bundler/inline'
gemfile do
source 'https://rubygems.org'
gem 'activerecord', '~> 7.0.0'
gem "activerecord-jdbc-adapter", "~> 70.0", platform: :jruby
end
require 'activerecord-jdbc-adapter'
ActiveRecord::Base.establish_connection("mysql2://root:root@mysql:3306/mysql")
ActiveRecord::Base.connection
How to test the change?
Green CI
All hail JRuby :D
Btw you may want to rebase on https://github.com/DataDog/dd-trace-rb/pull/3753 to pick up the libdatadog 10 upgrade. Sorry for the extra work :pray:
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.90%. Comparing base (
f0e28ec) to head (beb5284).
Additional details and impacted files
@@ Coverage Diff @@
## master #3752 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 1237 1237
Lines 74200 74260 +60
Branches 3598 3598
=======================================
+ Hits 72645 72705 +60
Misses 1555 1555
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.