dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

[SINT-1892] Run Datadog SCA in CI

Open harmonherring-pro opened this issue 1 year ago • 4 comments

2.0 Upgrade Guide notes

What does this PR do?

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • [ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • [ ] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

harmonherring-pro avatar Mar 28 '24 20:03 harmonherring-pro

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.27%. Comparing base (1b8fedf) to head (83c93c7). Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3562   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files        1274     1274           
  Lines       75205    75205           
  Branches     3544     3544           
=======================================
  Hits        73906    73906           
  Misses       1299     1299           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 28 '24 21:03 codecov-commenter

Hey! So I can see these changes match the ones in the integrations-core repo. But... how can I check that this is working fine? (I noticed you didn't fill in the PR template >_>).

I looked on GitLab and there was a warning for this pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-rb/-/pipelines/31064631 . Is that expected?

ivoanjo avatar Apr 05 '24 14:04 ivoanjo

It looks like all of the code added in this PR was executed but osv-scanner didn't find anything to scan, does it need to be configured?

p-datadog avatar May 15 '24 16:05 p-datadog

It looks like all of the code added in this PR was executed but osv-scanner didn't find anything to scan, does it need to be configured?

p-datadog avatar May 15 '24 16:05 p-datadog

Hey @harmonherring-pro what's the state of this PR? Should we go ahead and merge it? Or should we close it?

ivoanjo avatar Jul 17 '24 09:07 ivoanjo