dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

refactor: rename exception replay enablement variable

Open P403n1x87 opened this issue 1 year ago • 1 comments

We rename the exception replay enablement variable from DD_EXCEPTION_DEBUGGING_ENABLED to DD_EXCEPTION_REPLAY_ENABLED

Checklist

  • [ ] The PR description includes an overview of the change
  • [ ] The PR description articulates the motivation for the change
  • [ ] The change includes tests OR the PR description describes a testing strategy
  • [ ] The PR description notes risks associated with the change, if any
  • [ ] Newly-added code is easy to change
  • [ ] The change follows the library release note guidelines
  • [ ] The change includes or references documentation updates if necessary
  • [ ] Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Newly-added code is easy to change
  • [ ] Release note makes sense to a user of the library
  • [ ] If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

P403n1x87 avatar Jul 03 '24 10:07 P403n1x87

We need to upgrade envier to merge this

P403n1x87 avatar Jul 03 '24 10:07 P403n1x87

Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Project coverage is 10.54%. Comparing base (c728c68) to head (08b842c). Report is 43 commits behind head on main.

Files Patch % Lines
tests/debugging/exception/test_replay.py 0.00% 23 Missing :warning:
ddtrace/settings/exception_replay.py 0.00% 3 Missing :warning:
ddtrace/internal/telemetry/writer.py 0.00% 2 Missing :warning:
tests/debugging/mocking.py 0.00% 2 Missing :warning:
ddtrace/bootstrap/preload.py 66.66% 1 Missing :warning:
ddtrace/internal/telemetry/constants.py 0.00% 1 Missing :warning:
tests/telemetry/test_writer.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9708       +/-   ##
===========================================
- Coverage   74.30%   10.54%   -63.76%     
===========================================
  Files        1398     1368       -30     
  Lines      129930   127942     -1988     
===========================================
- Hits        96541    13494    -83047     
- Misses      33389   114448    +81059     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 11 '24 20:07 codecov-commenter