dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(ci): upgrade pyenv, upgrade python versions, add 3.13-dev

Open brettlangdon opened this issue 1 year ago • 3 comments

The one major change here is setting Python 3.12 as the default for the image instead of the existing 3.10.

I cannot remember why we have 3.10 as the default, so it felt harmless to change this to 3.12.

Checklist

  • [x] Change(s) are motivated and described in the PR description
  • [x] Testing strategy is described if automated tests are not included in the PR
  • [x] Risks are described (performance impact, potential for breakage, maintainability)
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Library release note guidelines are followed or label changelog/no-changelog is set
  • [x] Documentation is included (in-code, generated user docs, public corp docs)
  • [x] Backport labels are set (if applicable)
  • [x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • [x] Title is accurate
  • [x] All changes are related to the pull request's stated goal
  • [x] Description motivates each change
  • [x] Avoids breaking API changes
  • [x] Testing strategy adequately addresses listed risks
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Release note makes sense to a user of the library
  • [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [x] Backport labels are set in a manner that is consistent with the release branch maintenance policy

brettlangdon avatar Jun 27 '24 18:06 brettlangdon

Datadog Report

Branch report: brettlangdon/upgrade.pythons Commit report: 15294b7 Test service: dd-trace-py

:white_check_mark: 0 Failed, 135086 Passed, 41745 Skipped, 7h 32m 27.93s Total duration (2h 36m 28.47s time saved)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.16%. Comparing base (4acfde7) to head (b9e49b3). Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9665       +/-   ##
===========================================
- Coverage   74.65%   10.16%   -64.49%     
===========================================
  Files        1381     1351       -30     
  Lines      127965   126079     -1886     
===========================================
- Hits        95531    12819    -82712     
- Misses      32434   113260    +80826     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 27 '24 18:06 codecov-commenter

Benchmarks

Benchmark execution time: 2024-07-12 15:01:41

Comparing candidate commit ad742c171d5bd76efbb8ef5ee508dd41e9887776 in PR branch brettlangdon/upgrade.pythons with baseline commit af2e890318cb0b4401f923c65a3964de32a35ac4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

pr-commenter[bot] avatar Jun 27 '24 20:06 pr-commenter[bot]