dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix(rc): do not use multiprocessing.Queue when gevent is patched

Open brettlangdon opened this issue 1 year ago • 2 comments

Gevent is not compatible with multiprocessing.Queue.

Detect when gevent is patched and do no use the extra services multiprocessing.Queue

Checklist

  • [x] Change(s) are motivated and described in the PR description
  • [x] Testing strategy is described if automated tests are not included in the PR
  • [x] Risks are described (performance impact, potential for breakage, maintainability)
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [x] Documentation is included (in-code, generated user docs, public corp docs)
  • [x] Backport labels are set (if applicable)
  • [x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • [x] Title is accurate
  • [x] All changes are related to the pull request's stated goal
  • [x] Description motivates each change
  • [x] Avoids breaking API changes
  • [x] Testing strategy adequately addresses listed risks
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

brettlangdon avatar Jun 24 '24 20:06 brettlangdon

Benchmarks

Benchmark execution time: 2024-07-01 13:49:11

Comparing candidate commit bc0fb2d3edbe06aa65aaf2d3d90f6ce8254a8910 in PR branch brettlangdon/fix.gevent.rc with baseline commit 9c9b5a7e9d5977438cb98a6d86cf00b23f7fa3ff in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Jun 24 '24 22:06 pr-commenter[bot]

Datadog Report

Branch report: brettlangdon/fix.gevent.rc Commit report: bc0fb2d Test service: dd-trace-py

:white_check_mark: 0 Failed, 175095 Passed, 1194 Skipped, 11h 49m 35.81s Total duration (14m 19.84s time saved)

This PR can be closed. https://github.com/DataDog/dd-trace-py/pull/9701 should fix the problem now.

christophe-papazian avatar Jul 04 '24 09:07 christophe-papazian

closing in favor of alternate fix: https://github.com/DataDog/dd-trace-py/pull/9701, which has been merged already

wconti27 avatar Jul 08 '24 13:07 wconti27