dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

ci: add `importlib_metadata` to `test_get_distributions` [backport 2.9]

Open github-actions[bot] opened this issue 1 year ago • 2 comments

Backport 68bb423a2ed3ef23a87eb34d32ac96c8d1005016 from #9562 to 2.9.

Follow-up on: https://github.com/DataDog/dd-trace-py/pull/9467/files#r1642430035

Checklist

  • [x] Change(s) are motivated and described in the PR description
  • [x] Testing strategy is described if automated tests are not included in the PR
  • [x] Risks are described (performance impact, potential for breakage, maintainability)
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Library release note guidelines are followed or label changelog/no-changelog is set
  • [x] Documentation is included (in-code, generated user docs, public corp docs)
  • [x] Backport labels are set (if applicable)
  • [x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • [x] Title is accurate
  • [x] All changes are related to the pull request's stated goal
  • [x] Description motivates each change
  • [x] Avoids breaking API changes
  • [x] Testing strategy adequately addresses listed risks
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Release note makes sense to a user of the library
  • [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [x] Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions[bot] avatar Jun 17 '24 15:06 github-actions[bot]

Datadog Report

Branch report: backport-9562-to-2.9 Commit report: e30a290 Test service: dd-trace-py

:white_check_mark: 0 Failed, 1948 Passed, 14 Skipped, 4m 55.79s Total Time

Benchmarks

Benchmark execution time: 2024-07-19 16:40:31

Comparing candidate commit 948c1334ef85954f17975a51d2b8bc3c338a6599 in PR branch backport-9562-to-2.9 with baseline commit ffa42c66556ee9cd240905c40c8b10d6c3c66adf in branch 2.9.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Jun 17 '24 16:06 pr-commenter[bot]

Datadog Report

Branch report: backport-9562-to-2.9 Commit report: 948c133 Test service: dd-trace-py

:x: 1 Failed (1 Known Flaky), 31 Passed, 295 Skipped, 39.39s Total duration (16.35s time saved)

:x: Failed Tests (1)

  • test_get_distributions - test_packages.py - :snowflake: Known flaky - Details

    Expand for error
    ssert {'attrs', 'au...overage', ...} == {'attrs', 'au...overage', ...}
     Extra items in the left set:
     'importlib-resources'
     Extra items in the right set:
     'importlib_resources'
     Full diff:
       {
        'attrs',
        'autocommand',
        'backports.tarfile',
    ..
    

Blocked on this merging 🫠 : https://github.com/DataDog/dd-trace-py/pull/9879

erikayasuda avatar Jul 19 '24 16:07 erikayasuda

Closing because this is superceded by 9879 (which is also a backport to 2.9).

sanchda avatar Jul 19 '24 17:07 sanchda