dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix(profiling): fix encoding-related issues in stack v2

Open sanchda opened this issue 1 year ago • 11 comments

This adjusts the stack V2 API in order to conform to the new proposed echion renderer. This also fixes an encoding error in stack V2 which was caused by the old task renderer.

Checklist

  • [x] Change(s) are motivated and described in the PR description
  • [x] Testing strategy is described if automated tests are not included in the PR
  • [x] Risks are described (performance impact, potential for breakage, maintainability)
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Library release note guidelines are followed or label changelog/no-changelog is set
  • [x] Documentation is included (in-code, generated user docs, public corp docs)
  • [x] Backport labels are set (if applicable)
  • [x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • [x] Title is accurate
  • [x] All changes are related to the pull request's stated goal
  • [x] Description motivates each change
  • [x] Avoids breaking API changes
  • [x] Testing strategy adequately addresses listed risks
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Release note makes sense to a user of the library
  • [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [x] Backport labels are set in a manner that is consistent with the release branch maintenance policy

sanchda avatar Jun 10 '24 12:06 sanchda

Datadog Report

Branch report: sanchda/stack_v2.fix_tasks Commit report: 1a0c153 Test service: dd-trace-py

:white_check_mark: 0 Failed, 90 Passed, 1518 Skipped, 29m 52.14s Total duration (5m 7.3s time saved)

Benchmarks

Benchmark execution time: 2024-07-05 17:15:21

Comparing candidate commit 1a0c1537c471b5f6c63bb22cd7d0a3e2c7be7410 in PR branch sanchda/stack_v2.fix_tasks with baseline commit df7fada1eca955547d4f47fe6467477914035993 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Jun 10 '24 13:06 pr-commenter[bot]

Moving this back into draft. There's some kind of issue in CI I didn't anticipate.

sanchda avatar Jun 10 '24 20:06 sanchda

Looks like the issue was spurious (and already seen in other PRs--not novel to this one), reopening.

sanchda avatar Jun 11 '24 13:06 sanchda

Looks like CI doesn't have DD_STACK_V2_REQUIRED set and build failures from these typos were not caught.

This should be fixed now, since a recent PR removes that flag and forces these objects to be built on compatible platforms.

sanchda avatar Jun 25 '24 13:06 sanchda

/merge

sanchda avatar Jun 26 '24 19:06 sanchda

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jun 26 '24 19:06 dd-devflow[bot]

:steam_locomotive: MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jun 26 '24 19:06 dd-devflow[bot]

/remove

sanchda avatar Jun 26 '24 19:06 sanchda

:steam_locomotive: Devflow: /remove

dd-devflow[bot] avatar Jun 26 '24 19:06 dd-devflow[bot]

:warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar Jun 26 '24 19:06 dd-devflow[bot]

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport-9501-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da759a93a772d88120f4983d7fdf8c34699152f2
# Push it to GitHub
git push --set-upstream origin backport-9501-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport-9501-to-2.8.

github-actions[bot] avatar Jul 05 '24 17:07 github-actions[bot]

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport-9501-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da759a93a772d88120f4983d7fdf8c34699152f2
# Push it to GitHub
git push --set-upstream origin backport-9501-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport-9501-to-2.9.

github-actions[bot] avatar Jul 05 '24 17:07 github-actions[bot]