dd-trace-py
dd-trace-py copied to clipboard
fix(grpc): include missing args in error call
Small pr to fix some missing arguments in a grpc error call. No backports necessary.
Checklist
- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included in the PR
- [x] Risks are described (performance impact, potential for breakage, maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Library release note guidelines are followed or label
changelog/no-changelogis set - [x] Documentation is included (in-code, generated user docs, public corp docs)
- [x] Backport labels are set (if applicable)
- [x] If this PR changes the public interface, I've notified
@DataDog/apm-tees.
Reviewer Checklist
- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking API changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Can you explain why this doesn't have to be backported?
Can you explain why this doesn't have to be backported?
I modified the backport PR's to include this change.
Datadog Report
Branch report: conti/fix-grpc-error-with-args
Commit report: f7145b3
Test service: dd-trace-py
:white_check_mark: 0 Failed, 638 Passed, 248 Skipped, 4m 56.1s Total duration (35.25s time saved)
Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 6.76%. Comparing base (
5897cab) to head (760f1f4). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| ddtrace/contrib/grpc/aio_client_interceptor.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #9277 +/- ##
===========================================
- Coverage 75.73% 6.76% -68.98%
===========================================
Files 1285 1255 -30
Lines 121530 119684 -1846
===========================================
- Hits 92044 8098 -83946
- Misses 29486 111586 +82100
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Benchmarks
Benchmark execution time: 2024-05-15 19:24:17
Comparing candidate commit 760f1f4d466f0c1cc2e0d35aebcc13cbf2e6a17b in PR branch conti/fix-grpc-error-with-args with baseline commit 5897cabe7651f30b0f865ed211c84e1316b49628 in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.
Can you explain the testing strategy?
This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.