dd-trace-py
dd-trace-py copied to clipboard
add payload size to DSM stats for botocore
trafficstars
Checklist
- [ ] Change(s) are motivated and described in the PR description
- [ ] Testing strategy is described if automated tests are not included in the PR
- [ ] Risks are described (performance impact, potential for breakage, maintainability)
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Library release note guidelines are followed or label
changelog/no-changelogis set - [ ] Documentation is included (in-code, generated user docs, public corp docs)
- [ ] Backport labels are set (if applicable)
- [ ] If this PR changes the public interface, I've notified
@DataDog/apm-tees. - [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: conti/add-botocore-dsm-payload-size
Commit report: 68c8aee
Test service: dd-trace-py
:white_check_mark: 0 Failed, 238 Passed, 312 Skipped, 10m 26.47s Total duration (26m 36.3s time saved)
Benchmarks
Benchmark execution time: 2024-03-18 16:15:53
Comparing candidate commit 2b0143e718bd1fe51c581d0915d544052d4fab7f in PR branch conti/add-botocore-dsm-payload-size with baseline commit 0d681e08fb251bbd4dfd1e74ba6ecd89d45c9f9c in branch main.
Found 3 performance improvements and 2 performance regressions! Performance is the same for 172 metrics, 9 unstable metrics.
scenario:httppropagationextract-all_styles_all_headers
- 🟩
max_rss_usage[-911.208KB; -728.830KB] or [-4.172%; -3.337%]
scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match
- 🟥
max_rss_usage[+645.818KB; +720.198KB] or [+3.048%; +3.399%]
scenario:httppropagationextract-none_propagation_style
- 🟩
max_rss_usage[-665.152KB; -466.164KB] or [-3.048%; -2.136%]
scenario:sethttpmeta-obfuscation-send-querystring-disabled
- 🟩
max_rss_usage[-768.468KB; -532.831KB] or [-3.432%; -2.380%]
scenario:span-start
- 🟥
max_rss_usage[+922.738KB; +1006.887KB] or [+2.245%; +2.449%]