dd-trace-py
dd-trace-py copied to clipboard
chore(profiling): add lock profiling support to ddup
I'm working on adding some tests to this new libdatadog stuff and realized I never pushed the lock code. Oops!
Tests incoming in a separate PR, this is all still guarded behind a flag.
Checklist
- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included in the PR
- [x] Risks are described (performance impact, potential for breakage, maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Library release note guidelines are followed or label
changelog/no-changelogis set - [x] Documentation is included (in-code, generated user docs, public corp docs)
- [x] Backport labels are set (if applicable)
- [x] If this PR changes the public interface, I've notified
@DataDog/apm-tees. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: sanchda/ddup_add_lock_profiling
Commit report: eba9db8
Test service: dd-trace-py
:white_check_mark: 0 Failed, 188 Passed, 862 Skipped, 7m 31.69s Total duration (1h 15m 42.29s time saved)
Benchmarks
Benchmark execution time: 2024-04-18 14:57:08
Comparing candidate commit 49a8ebdb2454f0c09e57c7828264f332d69e0dbc in PR branch sanchda/ddup_add_lock_profiling with baseline commit 7904d56f27ad55fcb7f6bdc56b917fcd5b7484ed in branch main.
Found 0 performance improvements and 2 performance regressions! Performance is the same for 199 metrics, 9 unstable metrics.
scenario:httppropagationinject-with_all
- 🟥
max_rss_usage[+745.772KB; +795.143KB] or [+3.525%; +3.759%]
scenario:httppropagationinject-with_dd_origin
- 🟥
max_rss_usage[+0.995MB; +1.049MB] or [+4.767%; +5.021%]