dd-trace-py
dd-trace-py copied to clipboard
Add preliminary timeline support
Checklist
- [ ] Change(s) are motivated and described in the PR description
- [ ] Testing strategy is described if automated tests are not included in the PR
- [ ] Risks are described (performance impact, potential for breakage, maintainability)
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Library release note guidelines are followed or label
changelog/no-changelogis set - [ ] Documentation is included (in-code, generated user docs, public corp docs)
- [ ] Backport labels are set (if applicable)
- [ ] If this PR changes the public interface, I've notified
@DataDog/apm-tees. - [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: sanchda/add_timeline_ddup
Commit report: 8454ede
Test service: dd-trace-py
:white_check_mark: 0 Failed, 199 Passed, 857 Skipped, 11m 49.19s Total duration (1h 11m 6.28s time saved)
Benchmarks
Benchmark execution time: 2024-03-14 17:09:16
Comparing candidate commit 39268c2d12360807414e5335a25a6bb68fa669ea in PR branch sanchda/add_timeline_ddup with baseline commit e99c499b3dae162afe8d5d008c184f51f21e1398 in branch main.
Found 2 performance improvements and 2 performance regressions! Performance is the same for 149 metrics, 9 unstable metrics.
scenario:flasksimple-appsec-get
- 🟩
execution_time[-284.454µs; -236.791µs] or [-4.341%; -3.614%]
scenario:flasksimple-tracer
- 🟥
execution_time[+278.115µs; +318.962µs] or [+4.421%; +5.070%]
scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match
- 🟥
max_rss_usage[+663.185KB; +738.875KB] or [+3.132%; +3.489%]
scenario:samplingrules-low_match
- 🟩
max_rss_usage[-798.088KB; -575.711KB] or [-2.825%; -2.038%]
Closing as stale. Will reopen