dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat(asm): add exploit prevention LFI support

Open christophe-papazian opened this issue 1 year ago • 2 comments

Checklist

  • [ ] Change(s) are motivated and described in the PR description
  • [ ] Testing strategy is described if automated tests are not included in the PR
  • [ ] Risks are described (performance impact, potential for breakage, maintainability)
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [ ] Documentation is included (in-code, generated user docs, public corp docs)
  • [ ] Backport labels are set (if applicable)
  • [ ] If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

christophe-papazian avatar Mar 01 '24 12:03 christophe-papazian

Datadog Report

Branch report: christophe-papazian/exploit_prevention_stack_traces_support Commit report: b7a98ab Test service: dd-trace-py

:white_check_mark: 0 Failed, 148124 Passed, 20428 Skipped, 8h 21m 48.03s Total duration (1h 21m 39.1s time saved)

Benchmarks

Benchmark execution time: 2024-03-25 19:28:42

Comparing candidate commit e658581ae9fec676df2ec093e59a28bdc3670b5d in PR branch christophe-papazian/exploit_prevention_stack_traces_support with baseline commit 695540700a4fa0164bc62e20d3845c8041933d5b in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 200 metrics, 9 unstable metrics.

scenario:sethttpmeta-obfuscation-disabled

  • 🟥 max_rss_usage [+470.170KB; +710.706KB] or [+2.180%; +3.295%]

pr-commenter[bot] avatar Mar 01 '24 14:03 pr-commenter[bot]