dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(iast): add sqlalchemy allowlist

Open gnufede opened this issue 1 year ago • 2 comments

Checklist

  • [ ] Change(s) are motivated and described in the PR description
  • [ ] Testing strategy is described if automated tests are not included in the PR
  • [ ] Risks are described (performance impact, potential for breakage, maintainability)
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [ ] Documentation is included (in-code, generated user docs, public corp docs)
  • [ ] Backport labels are set (if applicable)
  • [ ] If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

gnufede avatar Feb 09 '24 11:02 gnufede

Benchmarks

Benchmark execution time: 2024-02-13 08:22:07

Comparing candidate commit 3120dbad44f818c33f256b70b8889b3464069697 in PR branch gnufede/iast-add-sqlalchemy-allowlist with baseline commit 73cb1769e2e3e2a79b5bfe67503e30f5110ab9a6 in branch main.

Found 5 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 9 unstable metrics.

scenario:httppropagationextract-empty_headers

  • 🟥 max_rss_usage [+713.441KB; +830.341KB] or [+2.437%; +2.837%]

scenario:httppropagationextract-full_t_id_datadog_headers

  • 🟩 max_rss_usage [-823.737KB; -726.190KB] or [-2.744%; -2.419%]

scenario:httppropagationextract-none_propagation_style

  • 🟥 max_rss_usage [+940.522KB; +1051.363KB] or [+3.242%; +3.624%]

scenario:httppropagationextract-valid_headers_basic

  • 🟩 max_rss_usage [-849.211KB; -722.834KB] or [-2.829%; -2.408%]

scenario:httppropagationextract-wsgi_large_header_no_matches

  • 🟩 max_rss_usage [-812.545KB; -691.096KB] or [-2.710%; -2.305%]

scenario:httppropagationextract-wsgi_medium_header_no_matches

  • 🟩 max_rss_usage [-785.171KB; -657.440KB] or [-2.621%; -2.195%]

scenario:httppropagationextract-wsgi_valid_headers_basic

  • 🟩 max_rss_usage [-749.060KB; -629.244KB] or [-2.499%; -2.099%]

pr-commenter[bot] avatar Feb 09 '24 18:02 pr-commenter[bot]

Datadog Report

Branch report: gnufede/iast-add-sqlalchemy-allowlist Commit report: 3120dba Test service: dd-trace-py

:white_check_mark: 0 Failed, 1406 Passed, 109855 Skipped, 18m 57.11s Total duration (1h 39m 23.3s time saved)