dd-trace-py
dd-trace-py copied to clipboard
feat: add twisted integration
Integration
This PR adds support for twisted. This includes patches for trace context propagation as well as support for the http client.
Links
- Integration docs: https://twistedmatrix.com/trac/
- Corp docs PR:
Checklist
- [x] Documentation added in
__init__.py. - [ ] Corp docs are updated.
- [ ] Entry added to
CHANGELOG.md.
Testing
- [x] Tests are added to CI.
- [x] Functionality is maintained from original library.
- [x] All Python versions that the library supports are tested.
- [x] All relevant library versions (including the latest) are tested.
- [ ] Global configuration
- [ ] Inherits
DD_SERVICE(if applicable) - [ ] Environment variables are provided for config options.
- [ ]
ddtrace.config.
- [ ] Inherits
- [ ] Instance configuration
- [ ] Pin overriding.
- [ ] Service name override (if applicable)
- [x] Async (if applicable)
- [x] Span parenting behaves as expected.
Codecov Report
Merging #1669 (655188f) into master (415c5cc) will decrease coverage by
0.78%. The diff coverage is7.17%.
@@ Coverage Diff @@
## master #1669 +/- ##
==========================================
- Coverage 83.31% 82.52% -0.79%
==========================================
Files 548 552 +4
Lines 37809 38213 +404
==========================================
+ Hits 31499 31537 +38
- Misses 6310 6676 +366
| Impacted Files | Coverage Δ | |
|---|---|---|
| ddtrace/contrib/twisted/patch.py | 0.00% <0.00%> (ø) |
|
| ddtrace/monkey.py | 89.33% <ø> (ø) |
|
| tests/contrib/twisted/test_twisted.py | 0.00% <0.00%> (ø) |
|
| tests/contrib/twisted/test_twisted_patch.py | 0.00% <0.00%> (ø) |
|
| ddtrace/contrib/twisted/__init__.py | 66.66% <66.66%> (ø) |
|
| ddtrace/context.py | 98.33% <100.00%> (+0.23%) |
:arrow_up: |
| tests/tracer/test_context.py | 100.00% <100.00%> (ø) |
|
| ddtrace/contrib/pymongo/parse.py | 90.29% <0.00%> (-0.98%) |
:arrow_down: |
| tests/profiling/exporter/test_http.py | 92.90% <0.00%> (-0.68%) |
:arrow_down: |
| tests/profiling/test_profiler.py | 90.60% <0.00%> (-0.68%) |
:arrow_down: |
| ... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 415c5cc...655188f. Read the comment docs.
@Kyle-Verhoog this pull request is now in conflict 😩
@Kyle-Verhoog this pull request is now in conflict 😩