dd-trace-py
dd-trace-py copied to clipboard
feat: add cyclone integration
Integration
This PR adds support for Cyclone.
Links
- Integration docs: http://cyclone.io/
- Corp docs PR:
Checklist
- [x] Usage and configuration documentation added in
__init__.py,docs/index.rstanddocs/integrations.rst. - [ ] Corp docs PR to add new integration to documentation.
- [x] Span metadata
- [x] Service (use
int_serviceorext_service). - [x] Span type should be one of these.
- [x] Resource
- [x] Service (use
- [x] Global configuration
- [x]
ddtrace.configentry is specified. - [x] Environment variables are provided for config options.
- [x]
- [x] Instance configuration
- [x] Pin overriding.
- [x] Service name override (if applicable).
- [x] Async
- [x] Span parenting behaves as expected.
- [x] Context propagation across async contexts.
- [x] HTTP
- [x] Distributed tracing propagation is implemented.
- [x] Use
trace_utils.set_http_metato set http tags
- [x] Tests
- [x] Tests are provided for all of the above.
- [x] Tests are added to CI (
.circleci/config.yml). - [x] Functionality is maintained from original library.
- [x] Patch test cases are added (see
test_django_patch.pyfor an example). - [x] All Python versions that the library supports are tested.
- [x] All significant library versions (including the latest) are tested. This typically includes every minor release going back a few years.
This includes support for
- tracing of all requests to the Cyclone framework
- distributed tracing
- header and query string tracing
- error recording

Codecov Report
Merging #1642 (6df1ab5) into master (415c5cc) will decrease coverage by
0.98%. The diff coverage is0.86%.
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 83.31% 82.32% -0.99%
==========================================
Files 548 554 +6
Lines 37809 38273 +464
==========================================
+ Hits 31499 31509 +10
- Misses 6310 6764 +454
| Impacted Files | Coverage Δ | |
|---|---|---|
| ddtrace/contrib/cyclone/patch.py | 0.00% <0.00%> (ø) |
|
| ddtrace/internal/context_manager.py | 89.18% <ø> (ø) |
|
| ddtrace/monkey.py | 89.33% <ø> (ø) |
|
| tests/contrib/cyclone/client.py | 0.00% <0.00%> (ø) |
|
| tests/contrib/cyclone/test_cyclone.py | 0.00% <0.00%> (ø) |
|
| tests/contrib/cyclone/test_cyclone_patch.py | 0.00% <0.00%> (ø) |
|
| tests/contrib/cyclone/testcase.py | 0.00% <0.00%> (ø) |
|
| ddtrace/contrib/cyclone/__init__.py | 66.66% <66.66%> (ø) |
|
| tests/profiling/test_profiler.py | 89.26% <0.00%> (-2.02%) |
:arrow_down: |
| ddtrace/profiling/exporter/http.py | 95.83% <0.00%> (-1.05%) |
:arrow_down: |
| ... and 12 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 415c5cc...020fa00. Read the comment docs.
@Kyle-Verhoog this pull request is now in conflict 😩
@Kyle-Verhoog this pull request is now in conflict 😩