dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat: add cyclone integration

Open Kyle-Verhoog opened this issue 5 years ago • 3 comments

Integration

This PR adds support for Cyclone.

Links

  • Integration docs: http://cyclone.io/
  • Corp docs PR:

Checklist

  • [x] Usage and configuration documentation added in __init__.py, docs/index.rst and docs/integrations.rst.
  • [ ] Corp docs PR to add new integration to documentation.
  • [x] Span metadata
  • [x] Global configuration
    • [x] ddtrace.config entry is specified.
    • [x] Environment variables are provided for config options.
  • [x] Instance configuration
    • [x] Pin overriding.
    • [x] Service name override (if applicable).
  • [x] Async
    • [x] Span parenting behaves as expected.
    • [x] Context propagation across async contexts.
  • [x] HTTP
  • [x] Tests
    • [x] Tests are provided for all of the above.
    • [x] Tests are added to CI (.circleci/config.yml).
    • [x] Functionality is maintained from original library.
    • [x] Patch test cases are added (see test_django_patch.py for an example).
    • [x] All Python versions that the library supports are tested.
    • [x] All significant library versions (including the latest) are tested. This typically includes every minor release going back a few years.

This includes support for

  • tracing of all requests to the Cyclone framework
  • distributed tracing
  • header and query string tracing
  • error recording

image

Kyle-Verhoog avatar Sep 04 '20 07:09 Kyle-Verhoog

Codecov Report

Merging #1642 (6df1ab5) into master (415c5cc) will decrease coverage by 0.98%. The diff coverage is 0.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
- Coverage   83.31%   82.32%   -0.99%     
==========================================
  Files         548      554       +6     
  Lines       37809    38273     +464     
==========================================
+ Hits        31499    31509      +10     
- Misses       6310     6764     +454     
Impacted Files Coverage Δ
ddtrace/contrib/cyclone/patch.py 0.00% <0.00%> (ø)
ddtrace/internal/context_manager.py 89.18% <ø> (ø)
ddtrace/monkey.py 89.33% <ø> (ø)
tests/contrib/cyclone/client.py 0.00% <0.00%> (ø)
tests/contrib/cyclone/test_cyclone.py 0.00% <0.00%> (ø)
tests/contrib/cyclone/test_cyclone_patch.py 0.00% <0.00%> (ø)
tests/contrib/cyclone/testcase.py 0.00% <0.00%> (ø)
ddtrace/contrib/cyclone/__init__.py 66.66% <66.66%> (ø)
tests/profiling/test_profiler.py 89.26% <0.00%> (-2.02%) :arrow_down:
ddtrace/profiling/exporter/http.py 95.83% <0.00%> (-1.05%) :arrow_down:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 415c5cc...020fa00. Read the comment docs.

codecov-io avatar Dec 17 '20 22:12 codecov-io

@Kyle-Verhoog this pull request is now in conflict 😩

mergify[bot] avatar Nov 10 '21 14:11 mergify[bot]

@Kyle-Verhoog this pull request is now in conflict 😩

mergify[bot] avatar Sep 26 '22 07:09 mergify[bot]