dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(ci): fix django snapshot timeouts

Open avara1986 opened this issue 1 year ago • 3 comments

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

avara1986 avatar Oct 23 '24 13:10 avara1986

CODEOWNERS have been resolved as:

tests/appsec/appsec_utils.py                                            @DataDog/asm-python
tests/contrib/django/test_django_snapshots.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/internal/test_module.py                                           @DataDog/debugger-python @DataDog/apm-core-python
tests/telemetry/test_telemetry_metrics_e2e.py                           @DataDog/apm-core-python
tests/utils.py                                                          @DataDog/python-guild
tests/webclient.py                                                      @DataDog/apm-core-python

github-actions[bot] avatar Oct 23 '24 13:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-10-24 21:04:17

Comparing candidate commit f958b3c5f2b6ddbed6e652f21c43664db3b5c83f in PR branch avara1986/ci_fix_django_snapshots with baseline commit 3fd669649c3d8547adccdb388396d1acca04fc75 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 326 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-392.779ns; -321.786ns] or [-9.755%; -7.992%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-483.495ns; -418.842ns] or [-11.175%; -9.681%]

pr-commenter[bot] avatar Oct 23 '24 14:10 pr-commenter[bot]

Datadog Report

Branch report: avara1986/ci_fix_django_snapshots Commit report: f958b3c Test service: dd-trace-py

:white_check_mark: 0 Failed, 1160 Passed, 126 Skipped, 30m 48.78s Total duration (8m 19.05s time saved)