dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore: fix envier dependency for the library

Open P403n1x87 opened this issue 1 year ago • 3 comments
trafficstars

We fix the library dependency on envier to the minor version. This allows for bugfixes to be pulled in, but ensure a more stable minor release to avoid breaking changes. We also remove the pinning where not required because envier is already installed by the main package.

Checklist

  • [x] PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

P403n1x87 avatar Oct 22 '24 12:10 P403n1x87

CODEOWNERS have been resolved as:

.riot/requirements/1215c62.txt                                          @DataDog/apm-python
.riot/requirements/132f882.txt                                          @DataDog/apm-python
.riot/requirements/1dcfbb2.txt                                          @DataDog/apm-python
.riot/requirements/bd5e098.txt                                          @DataDog/apm-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
.riot/requirements/1e6bfcb.txt                                          @DataDog/apm-python
.riot/requirements/1f540f4.txt                                          @DataDog/apm-python
.riot/requirements/6498eb0.txt                                          @DataDog/apm-python
.riot/requirements/c23a971.txt                                          @DataDog/apm-python

github-actions[bot] avatar Oct 22 '24 12:10 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-10-22 14:24:10

Comparing candidate commit 696ece0b1a767a09f312f65485e703331bfcd7e9 in PR branch chore/envier-dependency with baseline commit 50b335982edd0fc283efc8f416f7f4bb32548f04 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 333 metrics, 53 unstable metrics.

pr-commenter[bot] avatar Oct 22 '24 13:10 pr-commenter[bot]

Datadog Report

Branch report: chore/envier-dependency Commit report: 696ece0 Test service: dd-trace-py

:white_check_mark: 0 Failed, 1286 Passed, 0 Skipped, 31m 36.1s Total duration (6m 31.83s time saved)

This pull request has been automatically closed after a period of inactivity. After this much time, it will likely be easier to open a new pull request with the same changes than to update this one from the base branch. Please comment or reopen if you think this pull request was closed in error.

github-actions[bot] avatar Jan 22 '25 00:01 github-actions[bot]