dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Implement new SSI configuration telemetry

Open iamluc opened this issue 5 months ago • 1 comments

Description

Implement https://docs.google.com/document/d/1wydXj2fW0V0jaWU6W9pIbipT_AXD15tmbTtOPXFBEy4/edit?tab=t.nun42691l9k2 for PHP

https://datadoghq.atlassian.net/browse/INPLAT-577

System-tests PR: https://github.com/DataDog/system-tests/pull/4797

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [ ] Appropriate labels assigned.

iamluc avatar Jun 17 '25 15:06 iamluc

Benchmarks [ tracer ]

Benchmark execution time: 2025-07-21 16:24:12

Comparing candidate commit c525ae0dfbcd07a39ccacd36b5d6bbd9f1a571a8 in PR branch luc/ssi-config-telemetry with baseline commit 779da23c7ea5888308b647bbdb71fc69bf728fb3 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-5.819µs; -5.458µs] or [-8.686%; -8.148%]

pr-commenter[bot] avatar Jun 17 '25 16:06 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.80%. Comparing base (779da23) to head (c525ae0). Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
- Coverage   61.92%   61.80%   -0.12%     
==========================================
  Files         140      140              
  Lines       12356    12356              
  Branches     1616     1616              
==========================================
- Hits         7651     7637      -14     
- Misses       3995     4008      +13     
- Partials      710      711       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 779da23...c525ae0. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 03 '25 12:07 codecov-commenter