dd-trace-php
dd-trace-php copied to clipboard
internal(prof): configurable upload compression
Description
This adds support for DD_PROFILING_UPLOAD_COMPRESSION. It has 4 values:
- off
- on
- lz4
- zstd
"on" is the default, and aliases one of the other forms of compression. This is not expected to be used by end-users, but rather development and testing and benchmarking cost trade-offs. Specifically, we're testing out zstd.
Reviewer checklist
- [ ] Test coverage seems ok.
- [ ] Appropriate labels assigned.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.26%. Comparing base (
0f03e1a) to head (4d78bf7).
Additional details and impacted files
@@ Coverage Diff @@
## master #3259 +/- ##
============================================
+ Coverage 76.35% 79.26% +2.90%
Complexity 2948 2948
============================================
Files 145 118 -27
Lines 16082 11633 -4449
Branches 1110 0 -1110
============================================
- Hits 12280 9221 -3059
+ Misses 3225 2412 -813
+ Partials 577 0 -577
| Flag | Coverage Δ | |
|---|---|---|
| appsec-extension | ? |
|
| tracer-php | 79.26% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 28 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0f03e1a...4d78bf7. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Benchmarks [ profiler ]
Benchmark execution time: 2025-05-21 16:40:22
Comparing candidate commit 4d78bf7122b25fd138c9914c8dffc7b219318e7a in PR branch PROF-11833-Support-DD_PROFILING_UPLOAD_COMPRESSION-in-PHP with baseline commit 0f03e1ab97ea28957ef8b6149b470a287d7b16ca in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.