dd-trace-php
dd-trace-php copied to clipboard
Send some telemetry logs from the helper
Description
Sends telemetry logs related to remote config from the appsec helper.
Depends on https://github.com/DataDog/libdatadog/pull/1051
Reviewer checklist
- [ ] Test coverage seems ok.
- [ ] Appropriate labels assigned.
Codecov Report
Attention: Patch coverage is 33.52113% with 236 lines in your changes missing coverage. Please review.
Project coverage is 61.82%. Comparing base (
49ab6e4) to head (9fa8020). Report is 1 commits behind head on master.
:x: Your patch status has failed because the patch coverage (33.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
:exclamation: There is a different number of reports uploaded between BASE (49ab6e4) and HEAD (9fa8020). Click for more details.
HEAD has 12 uploads less than BASE
Flag BASE (49ab6e4) HEAD (9fa8020) 14 2
Additional details and impacted files
@@ Coverage Diff @@
## master #3236 +/- ##
==========================================
- Coverage 70.39% 61.82% -8.57%
==========================================
Files 102 140 +38
Lines 10416 12315 +1899
Branches 1564 1617 +53
==========================================
+ Hits 7332 7614 +282
- Misses 2387 3989 +1602
- Partials 697 712 +15
| Files with missing lines | Coverage Δ | |
|---|---|---|
| appsec/src/extension/commands/config_sync.c | 100.00% <100.00%> (ø) |
|
| appsec/src/extension/commands/request_shutdown.c | 78.15% <100.00%> (+0.10%) |
:arrow_up: |
| appsec/src/helper/engine.hpp | 100.00% <ø> (ø) |
|
| appsec/src/helper/json_helper.cpp | 65.21% <ø> (ø) |
|
| appsec/src/helper/network/proto.hpp | 93.22% <ø> (ø) |
|
| appsec/src/helper/parameter.hpp | 100.00% <ø> (ø) |
|
| appsec/src/helper/remote_config/client.hpp | 100.00% <ø> (ø) |
|
| appsec/src/helper/remote_config/client_handler.cpp | 54.28% <100.00%> (ø) |
|
| appsec/src/helper/remote_config/client_handler.hpp | 20.00% <ø> (ø) |
|
| ...helper/remote_config/listeners/engine_listener.cpp | 90.19% <ø> (ø) |
|
| ... and 17 more |
... and 38 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 49ab6e4...9fa8020. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Benchmarks [ tracer ]
Benchmark execution time: 2025-07-07 13:43:56
Comparing candidate commit 9fa80205488d3b8d5bc9617a7361e5cd4fe34b7c in PR branch glopes/appsec-log-submission-ffi with baseline commit 49ab6e4c9cbbab373159a798398dbf201ed602bf in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.
Benchmarks [ appsec ]
Benchmark execution time: 2025-07-07 13:57:55
Comparing candidate commit 9fa80205488d3b8d5bc9617a7361e5cd4fe34b7c in PR branch glopes/appsec-log-submission-ffi with baseline commit 49ab6e4c9cbbab373159a798398dbf201ed602bf in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.