dd-trace-php
dd-trace-php copied to clipboard
Updating Default Value of DD_TRACE_RATE_LIMIT
Description
Updating the default value for the DD_TRACE_RATE_LIMIT from 0 to 100 to match RFC and most of all other languages.
Related Jira: https://datadoghq.atlassian.net/browse/APMAPI-496
Reviewer checklist
- [ ] Test coverage seems ok.
- [ ] Appropriate labels assigned.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.37%. Comparing base (
093ef34) to head (e2beb4f).
:exclamation: There is a different number of reports uploaded between BASE (093ef34) and HEAD (e2beb4f). Click for more details.
HEAD has 21 uploads less than BASE
Flag BASE (093ef34) HEAD (e2beb4f) tracer-php 12 0 tracer-extension 9 0
Additional details and impacted files
@@ Coverage Diff @@
## master #2907 +/- ##
============================================
- Coverage 78.21% 68.37% -9.85%
============================================
Files 173 27 -146
Lines 18752 4038 -14714
Branches 988 988
============================================
- Hits 14667 2761 -11906
+ Misses 3544 736 -2808
Partials 541 541
| Flag | Coverage Δ | |
|---|---|---|
| appsec-extension | 68.37% <ø> (ø) |
|
| tracer-extension | ? |
|
| tracer-php | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 146 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 093ef34...e2beb4f. Read the comment docs.
Benchmarks [ tracer ]
Benchmark execution time: 2024-10-25 22:01:56
Comparing candidate commit e2beb4fda1b303cb2e827d951286219f1cdba741 in PR branch maximo/consistent-rate-limit-config with baseline commit 093ef34caa83c8b83d53d10cffc130f0fd88a1df in branch master.
Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.
scenario:HookBench/benchWithoutHook
- 🟥
execution_time[+2.386µs; +7.298µs] or [+2.934%; +8.975%]
scenario:MessagePackSerializationBench/benchMessagePackSerialization
- 🟩
execution_time[-12.857µs; -3.903µs] or [-7.527%; -2.285%]
scenario:PDOBench/benchPDOBaseline
- 🟩
execution_time[-13.374µs; -8.274µs] or [-7.050%; -4.362%]
scenario:PDOBench/benchPDOBaseline-opcache
- 🟩
execution_time[-13.961µs; -12.999µs] or [-7.292%; -6.790%]