dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

feat(profiling): Add fatals and thread start/end events to timeline

Open realFlowControl opened this issue 1 year ago • 3 comments

Description

This PR will add timeline events for:

  • thread start
  • thread end
  • fatals (out-of-memory, out-of-time, division-by-zero, ... and any unhandled exception)

image

PROF-10117 PROF-10118 PROF-10119

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [x] Appropriate labels assigned.

realFlowControl avatar Aug 29 '24 13:08 realFlowControl

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.10%. Comparing base (b3fd817) to head (008a41a). Report is 444 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2820   +/-   ##
=========================================
  Coverage     82.10%   82.10%           
  Complexity     2527     2527           
=========================================
  Files           108      108           
  Lines         10358    10358           
=========================================
  Hits           8504     8504           
  Misses         1854     1854           
Flag Coverage Δ
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3fd817...008a41a. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Aug 29 '24 14:08 codecov-commenter

Benchmarks

Benchmark execution time: 2024-09-11 15:18:56

Comparing candidate commit 2d130a9ea89f4b209daaf538cbb5a16e3856f7cc in PR branch florian/memory-limit-in-timline with baseline commit 186011fbc108dbb2761583f32f24b8240c982704 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics.

scenario:walk_stack/1

  • 🟩 wall_time [-366.025ns; -361.991ns] or [-2.947%; -2.914%]

pr-commenter[bot] avatar Aug 29 '24 14:08 pr-commenter[bot]

Benchmarks [ profiler ]

Benchmark execution time: 2024-11-06 14:26:25

Comparing candidate commit 008a41a50688b85dc53d51d446e82fd214a14d58 in PR branch florian/memory-limit-in-timline with baseline commit b3fd817475b69849922445914587522feeb4ddaa in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Oct 14 '24 13:10 pr-commenter[bot]