dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

Dynamic configuration and live debugger

Open bwoebi opened this issue 1 year ago • 2 comments

bwoebi avatar Aug 19 '24 13:08 bwoebi

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (b8fde57) to head (2e28bde). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
zend_abstract_interface/hook/hook.c 54.54% 10 Missing :warning:
..._abstract_interface/interceptor/php7/interceptor.c 50.00% 2 Missing :warning:
zend_abstract_interface/config/config.c 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2796      +/-   ##
============================================
- Coverage     80.97%   80.91%   -0.06%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14683    14704      +21     
============================================
+ Hits          11889    11898       +9     
- Misses         2794     2806      +12     
Flag Coverage Δ
tracer-extension 78.09% <55.17%> (-0.18%) :arrow_down:
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
zend_abstract_interface/config/config_ini.c 73.00% <100.00%> (ø)
zend_abstract_interface/exceptions/exceptions.c 91.80% <ø> (ø)
zend_abstract_interface/exceptions/exceptions.h 83.33% <100.00%> (ø)
zend_abstract_interface/hook/hook.h 100.00% <ø> (ø)
zend_abstract_interface/config/config.c 94.06% <0.00%> (-0.05%) :arrow_down:
..._abstract_interface/interceptor/php7/interceptor.c 89.56% <50.00%> (-0.26%) :arrow_down:
zend_abstract_interface/hook/hook.c 54.80% <54.54%> (-0.19%) :arrow_down:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8fde57...2e28bde. Read the comment docs.

codecov-commenter avatar Aug 29 '24 12:08 codecov-commenter

Benchmarks

Benchmark execution time: 2024-09-09 19:59:44

Comparing candidate commit a57fbfa608ac9ccc44b66cf7e09b5b6c43c664ec in PR branch bob/live-debugger with baseline commit bcb0c30d9f026caf8d2f0571f6743707ba4cc9f6 in branch master.

Found 16 performance improvements and 7 performance regressions! Performance is the same for 155 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-621.581µs; -391.699µs] or [-19.976%; -12.588%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-584.694µs; -408.426µs] or [-18.191%; -12.707%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-706.689µs; -497.231µs] or [-20.268%; -14.261%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-641.657µs; -436.663µs] or [-17.759%; -12.086%]

scenario:LaravelBench/benchLaravelBaseline

  • 🟩 execution_time [-407.611µs; -197.989µs] or [-13.146%; -6.386%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟩 execution_time [-475.336µs; -304.164µs] or [-14.529%; -9.297%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-558.756µs; -371.904µs] or [-15.816%; -10.527%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-728.337µs; -519.563µs] or [-19.198%; -13.695%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.218µs; -8.142µs] or [-6.764%; -5.390%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+128.727µs; +134.061µs] or [+50.536%; +52.630%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+121.006µs; +124.346µs] or [+44.267%; +45.489%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+128.483µs; +131.611µs] or [+46.327%; +47.455%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+126.123µs; +131.219µs] or [+41.250%; +42.917%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+194.982µs; +199.068µs] or [+80.189%; +81.870%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟥 execution_time [+190.588µs; +194.360µs] or [+69.031%; +70.397%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-415.545µs; -364.395µs] or [-6.667%; -5.846%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-450.131µs; -359.649µs] or [-7.053%; -5.635%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-825.588µs; -772.572µs] or [-11.315%; -10.589%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-830.333µs; -752.287µs] or [-11.186%; -10.135%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+6.371µs; +11.529µs] or [+3.751%; +6.788%]

scenario:WordPressBench/benchWordPressBaseline-opcache

  • 🟩 execution_time [-605.985µs; -486.655µs] or [-2.696%; -2.165%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-25.917ms; -25.814ms] or [-85.591%; -85.252%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-4.359ms; -4.124ms] or [-14.315%; -13.543%]

pr-commenter[bot] avatar Aug 29 '24 13:08 pr-commenter[bot]