dd-trace-php icon indicating copy to clipboard operation
dd-trace-php copied to clipboard

[Don't merge] enable sidecar in web tests

Open hoolioh opened this issue 1 year ago • 1 comments
trafficstars

Description

Reviewer checklist

  • [ ] Test coverage seems ok.
  • [ ] Appropriate labels assigned.

hoolioh avatar Jun 21 '24 12:06 hoolioh

Benchmarks

Benchmark execution time: 2024-06-25 08:57:59

Comparing candidate commit ea611a58c4da640280ed124976452cf3bdef61eb in PR branch julio/enable-sidecar-in-web-tests with baseline commit 231d5bd0d18453dff8e49b630445f778fbb8c57c in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-17.905µs; -14.470µs] or [-9.435%; -7.625%]

pr-commenter[bot] avatar Jun 21 '24 13:06 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.75%. Comparing base (f87446c) to head (9ea3c35). Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2729      +/-   ##
============================================
- Coverage     80.91%   79.75%   -1.17%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14706    14706              
============================================
- Hits          11900    11729     -171     
- Misses         2806     2977     +171     
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 80.45% <ø> (-1.66%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f87446c...9ea3c35. Read the comment docs.

codecov-commenter avatar Oct 02 '24 16:10 codecov-commenter