dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Not possible to disable `appsec` codepaths

Open tommoor opened this issue 1 year ago • 1 comments

This might seem like a small issue, but I'm having huge problems with this particular code path exhausting system memory which I'll file an issue for once I'm confident of reproduction steps. In the meantime being unable to disable the code from running when there is seemingly a setting to do so is problematic.

Expected behaviour

tracer.init({
  appsec: { enabled: false },
})

or

tracer.init({
  appsec: false,
})

Should prevent /appsec/ codepaths from running

Actual behaviour

RemoteConfigManager is still polling, making requests etc.

image

Here, using 43% of heap – it should be completely disabled!

image

Environment

  • Operation system: Ubuntu 4.8.4
  • Node.js version: 20 LTS
  • Tracer version: 4.20.0
  • Agent version: N/A
  • Relevant library versions:

tommoor avatar Dec 05 '23 01:12 tommoor